Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.15.z] [6.15] negative test for webhook task #13175

Merged

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #13049

Problem Statement

The "Deliver webhook..." task for the triggered hook previously succeeded even If the webhook execution failed for some reason. This will change in 6.15

Solution

I'm adding a negative test to cover this scenario. Note that the upstream PR isn't merged yet, so prt trigger would fail atm

Related Issues

SAT-21112

negative test for webhook task

(cherry picked from commit 37da211)
@Satellite-QE Satellite-QE requested a review from a team as a code owner November 23, 2023 13:22
@Satellite-QE Satellite-QE added 6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Nov 23, 2023
@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Nov 23, 2023
@pondrejk
Copy link
Contributor

trigger: test-robottelo
pytest: tests/foreman/api/test_webhook.py -k test_negative_event_task_failed

@pondrejk pondrejk merged commit fab4b7a into 6.15.z Nov 24, 2023
13 of 14 checks passed
@pondrejk pondrejk deleted the cherry-pick-6.15.z-37da211c840f6d92cbdb647140a48c9de5f8fea5 branch November 24, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants