Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create distinction between the product-ready OS and the product WFs #13177

Conversation

ogajduse
Copy link
Member

@ogajduse ogajduse commented Nov 23, 2023

Problem Statement

There is no distinction between content host deployment workflows and workflows to deploy the operating system on which the product is supposed to be installed. That causes issues in the PIT server testing scenario.
We would like to add a test to install Satellite and Capsule to the test collection, but we need to have a separate content host deployment workflow and the sat_ready_rhel and cap_ready_rhel workflows. That is due to the need to install the product on top of a non-released OS that we deploy using a workflow that is different from the one that we use for the content host deployment.

Solution

Create a distinction between the two workflows in the configuration and use the configuration.

Related Issues

satelliteqe/satellite-jenkins!1173
SAT-21475

@ogajduse ogajduse requested a review from rmynar November 23, 2023 14:49
@ogajduse ogajduse self-assigned this Nov 23, 2023
@ogajduse ogajduse changed the title Create a distinction between the product-ready OS and the product WFs Create distinction between the product-ready OS and the product WFs Nov 23, 2023
conf/capsule.yaml.template Outdated Show resolved Hide resolved
robottelo/config/validators.py Outdated Show resolved Hide resolved
@ogajduse ogajduse added CherryPick PR needs CherryPick to previous branches 6.12.z Introduced in or relating directly to Satellite 6.12 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Nov 23, 2023
@ogajduse ogajduse force-pushed the feat/distinction-in-product-n-os-workflow branch from d92e11c to 06ca697 Compare November 23, 2023 16:06
Copy link
Member

@JacobCallahan JacobCallahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes requested, but overall ACK on the proposed change.

conf/capsule.yaml.template Outdated Show resolved Hide resolved
pytest_fixtures/core/sat_cap_factory.py Outdated Show resolved Hide resolved
@rmynar
Copy link
Contributor

rmynar commented Nov 29, 2023

+1 to rename DEPLOY_WORKFLOW to DEPLOY_WORKFLOWS.

This solution also seems to be suitable for FIPS testing.

@ogajduse ogajduse force-pushed the feat/distinction-in-product-n-os-workflow branch from 06ca697 to 6265eea Compare November 30, 2023 12:26
@ogajduse ogajduse marked this pull request as ready for review November 30, 2023 12:27
@ogajduse ogajduse requested a review from a team as a code owner November 30, 2023 12:27
@ogajduse
Copy link
Member Author

Config migration(s) were introduced in the latest changes. This mechanism is pretty simple and smoothes the transition from the old configuration.
I would like to hear your feedback on it.

Copy link
Member

@JacobCallahan JacobCallahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat solution with the migration, so just a couple of minor things!

conf/migrations.py Outdated Show resolved Hide resolved
conf/dynaconf_hooks.py Outdated Show resolved Hide resolved
@ogajduse ogajduse force-pushed the feat/distinction-in-product-n-os-workflow branch from 6265eea to be5f1e7 Compare December 5, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants