Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that concurrency level is honored #13198

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

lhellebr
Copy link
Contributor

Problem Statement

Concurrency has been reworked in dynflow

Solution

Add a test for concurrency level being honored

trigger: test-robottelo
pytest: tests/foreman/cli/test_remoteexecution.py::TestAnsibleREX::test_positive_run_serial

@lhellebr lhellebr added CherryPick PR needs CherryPick to previous branches 6.15.z Introduced in or relating directly to Satellite 6.15 labels Nov 28, 2023
@lhellebr lhellebr requested a review from a team as a code owner November 28, 2023 14:49
@lhellebr lhellebr changed the title Set that concurrency level is honored Check that concurrency level is honored Nov 28, 2023
Copy link
Contributor

@Griffin-Sullivan Griffin-Sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just a question about the @host syntax

output_msgs = []
template_file = f"/root/{gen_string('alpha')}.template"
target_sat.execute(
f"echo 'rm /root/test-<%= @host %>; echo $(date +%s) >> /root/test-<%= @host %>; sleep 120; echo $(date +%s) >> /root/test-<%= @host %>' > {template_file}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does the <%= @host %> part do? Is this specific to Job Templates?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an ERB syntax and it outputs hostname

@pondrejk
Copy link
Contributor

trigger: test-robottelo
pytest: tests/foreman/cli/test_remoteexecution.py::TestAnsibleREX::test_positive_run_serial

@pondrejk pondrejk added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Nov 30, 2023
@pondrejk pondrejk merged commit 40223b2 into SatelliteQE:master Nov 30, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants