[Test Fix] Updating Tools repo to Utils repo in the recommended repos test #13223

ColeHiggins2 · 2023-11-29T15:21:10Z

The Tools repository was removed and is not longer in the recommended repo list. Switching the repository check to use the Utils and Capsule repositories instead

vijaysawant

Can you please update repo names from :expectedresults: 2? Capsule/Tools would be Capsule/Utils
Suggested new variable name, cap_tool_repos would be cap_utils_repos
query about assertion statement

One more thing I realised, test would failed in 6.15 due to use of fixture module_entitlement_manifest_org, please use alternative module_sca_manifest_org

tests/foreman/ui/test_repository.py

vijaysawant

Could you please take a look into suggested points? I have given collective feedback.
I can see requested changes have been completed, Ack on basis of that changes.
Please run PRT comment.

lhellebr · 2023-12-22T15:21:56Z

Please run PRT for affected tests

vijaysawant · 2024-01-15T11:20:21Z

trigger: test-robottelo
pytest: tests/foreman/ui/test_repository.py -k test_positive_recommended_repos

Gauravtalreja1 · 2024-01-18T09:46:49Z

tests/foreman/ui/test_repository.py

@@ -942,10 +942,10 @@ def test_positive_recommended_repos(session, module_entitlement_manifest_org):
        cap_tool_repos = [
            repo['name']
            for repo in rrepos_on
-            if 'Tools' in repo['name'] or 'Capsule' in repo['name']
+            if 'Utils' in repo['name'] or 'Capsule' in repo['name']
        ]
        cap_tools_repos = [repo for repo in cap_tool_repos if repo.split()[4] != sat_version]


I think instead of checking this for != sat_version, we should verify if n-1 repos are being suggested for capsule and utils repos

these repos should always match the sat version. so if any do not, then we throw the error message

I tested locally, as in updated code for variable cap_utils_main_repos, getting sat_version n-1 value, as you suggested @Gauravtalreja1
We can assert currect sat version and the sat version which found in repo names (in cap_utils_main_repos list) does not same, as per the step number 3

The current code is checking that ANY Repository not equal to the current sat version is not there. I don't see a reason to make it ONLY n-1.

yes, I think with n-1 it will be more explicite and efficient assertion here, which would all repositories equal to n-1 versions instead of checking not equal to current sat versions

@ColeHiggins2 ^

@Gauravtalreja1 my observation
On one of older snap version of 6.15 snap 3.0 I had seen 6.14 repos of capsule/maintain/Utils but on latest snap verson of 6.15 snap 9.0 I couldn't see.

I believe that on Satellite of version N only the N capsule/maintain/utils repos should be recommended. In other words, N-1, N-2, and all older repos should be missing.
@Gauravtalreja1, can you describe why you propose to check N-1 only?

@Gauravtalreja1 my observation On one of older snap version of 6.15 snap 3.0 I had seen 6.14 repos of capsule/maintain/Utils but on latest snap verson of 6.15 snap 9.0 I couldn't see.

This is expected behavior. at some point between snap 3 and 9, 6.14 repos were removed from recommended.

tests/foreman/ui/test_repository.py

rplevka · 2024-01-26T13:51:18Z

Pending other requester comments

ogajduse

co-reviewed with @rplevka.

ACK, pending @Gauravtalreja1 and @vijaysawant comments.

tests/foreman/ui/test_repository.py

ColeHiggins2 · 2024-02-05T20:59:29Z

trigger: test-robottelo
pytest: tests/foreman/ui/test_repository.py -k test_positive_recommended_repos

vijaysawant

As per suggestion from @Gauravtalreja1 and @ogajduse I have tested this PR by making changes locally, working fine.
@ColeHiggins2 you need to incorporate the suggested changes
run pre-commit
force push

tests/foreman/ui/test_repository.py

vijaysawant · 2024-02-06T08:32:54Z

tests/foreman/ui/test_repository.py

@@ -942,10 +942,10 @@ def test_positive_recommended_repos(session, module_entitlement_manifest_org):
        cap_tool_repos = [
            repo['name']
            for repo in rrepos_on
-            if 'Tools' in repo['name'] or 'Capsule' in repo['name']
+            if 'Utils' in repo['name'] or 'Capsule' in repo['name']
        ]
        cap_tools_repos = [repo for repo in cap_tool_repos if repo.split()[4] != sat_version]


I tested locally, as in updated code for variable cap_utils_main_repos, getting sat_version n-1 value, as you suggested @Gauravtalreja1
We can assert currect sat version and the sat version which found in repo names (in cap_utils_main_repos list) does not same, as per the step number 3

tests/foreman/ui/test_repository.py

vijaysawant · 2024-02-13T14:36:45Z

trigger: test-robottelo
pytest: tests/foreman/ui/test_repository.py -k test_positive_recommended_repos
env:
ROBOTTELO_server__deploy_workflow: 'deploy-satellite'
ROBOTTELO_server__deploy_arguments__deploy_rhel_version: '8'
ROBOTTELO_server__deploy_arguments__deploy_sat_version: '6.14'

Satellite-QE · 2024-02-13T14:42:50Z

PRT Result

Build Number: 5700
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_repository.py -k test_positive_recommended_repos
Test Result : ================ 33 deselected, 10 warnings, 1 error in 49.31s =================

Satellite-QE · 2024-02-13T14:47:53Z

PRT Result

Build Number: 5701
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_repository.py -k test_positive_recommended_repos
Test Result : ================ 33 deselected, 10 warnings, 1 error in 44.50s =================

sambible · 2024-02-13T16:52:41Z

trigger: test-robottelo
pytest: tests/foreman/ui/test_repository.py -k test_positive_recommended_repos

sambible

logic looks good, will merge when we can see a passing PRT run.

Satellite-QE · 2024-02-13T17:14:39Z

PRT Result

Build Number: 5703
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_repository.py -k test_positive_recommended_repos
Test Result : ========== 1 failed, 33 deselected, 12 warnings in 754.63s (0:12:34) ===========

vijaysawant · 2024-02-14T11:39:25Z

trigger: test-robottelo
pytest: tests/foreman/ui/test_repository.py -k test_positive_recommended_repos
env:
    ROBOTTELO_server__deploy_workflow: 'deploy-satellite'
    ROBOTTELO_server__deploy_arguments__deploy_rhel_version: '8'
    ROBOTTELO_server__deploy_arguments__deploy_sat_version: '6.14'

Satellite-QE · 2024-02-14T11:48:08Z

PRT Result

Build Number: 5717
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_repository.py -k test_positive_recommended_repos
Test Result : ================ 33 deselected, 10 warnings, 1 error in 49.73s =================

Gauravtalreja1

Ack, with one pending comment from earlier, let me know what you think

vsedmik · 2024-02-15T10:33:41Z

trigger: test-robottelo
pytest: tests/foreman/ui/test_repository.py -k test_positive_recommended_repos
env:
  ROBOTTELO_server__deploy_workflow: 'deploy-satellite'
  ROBOTTELO_server__deploy_arguments__deploy_rhel_version: '8'
  ROBOTTELO_server__deploy_arguments__deploy_sat_version: '6.14.2'
  ROBOTTELO_server__deploy_arguments__deploy_snap_version: '3.0'

Satellite-QE · 2024-02-15T10:56:15Z

PRT Result

Build Number: 5747
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_repository.py -k test_positive_recommended_repos
Test Result : ========== 1 failed, 33 deselected, 12 warnings in 858.26s (0:14:18) ===========

vsedmik · 2024-02-15T11:13:28Z

PRT failed to enable recommended repos in 6.14. Do we need to CP something in Airgun?

11:56:02          with session:
11:56:02              session.organization.select(module_sca_manifest_org.name)
11:56:02  >           rrepos_on = session.redhatrepository.read(recommended_repo='on')
...
11:56:02  >           raise NavigationTriesExceeded(self._name)
11:56:02  E           navmazing._errors.NavigationTriesExceeded: Navigation failed to reach [All] in the specified tries
...
11:56:02  >           raise NoSuchElementException(f"Could not find an element {repr(locator)}") from None
11:56:02  E           selenium.common.exceptions.NoSuchElementException: Message: Could not find an element Locator(by='xpath', locator='.//nav[@class="pf-c-nav" and @label="Global" or @aria-label="Global"]'); For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

vsedmik · 2024-02-15T15:36:07Z

trigger: test-robottelo
pytest: tests/foreman/ui/test_repository.py -k test_positive_recommended_repos

ColeHiggins2 · 2024-02-15T15:45:42Z

All comments are addressed, Code is reviewed. Moving to draft until 6.15 airgun fix is merged

Satellite-QE · 2024-02-15T15:56:26Z

PRT Result

Build Number: 5757
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_repository.py -k test_positive_recommended_repos
Test Result : ========== 1 failed, 33 deselected, 12 warnings in 884.45s (0:14:44) ===========

vsedmik · 2024-02-15T16:03:18Z

trigger: test-robottelo
pytest: tests/foreman/ui/test_repository.py -k test_positive_recommended_repos
env:
  ROBOTTELO_server__deploy_workflow: 'deploy-satellite'
  ROBOTTELO_server__deploy_arguments__deploy_rhel_version: '8'
  ROBOTTELO_server__deploy_arguments__deploy_sat_version: '6.15.0'
  ROBOTTELO_server__deploy_arguments__deploy_snap_version: '9.0'

Satellite-QE · 2024-02-15T16:25:00Z

PRT Result

Build Number: 5758
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_repository.py -k test_positive_recommended_repos
Test Result : ========== 1 failed, 33 deselected, 12 warnings in 810.44s (0:13:30) ===========

github-actions · 2024-04-01T05:35:15Z

This pull request has not been updated in the past 45 days.

lhellebr · 2024-04-08T12:39:58Z

@ColeHiggins2 should we close this?

github-actions · 2024-05-25T05:34:28Z

This pull request has not been updated in the past 45 days.

github-actions · 2024-06-01T05:35:56Z

This pull request is now being closed after stale warnings.

ColeHiggins2 added Easy Fix :) Easiest Fix to review and quick merge request. CherryPick PR needs CherryPick to previous branches 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Nov 29, 2023

ColeHiggins2 self-assigned this Nov 29, 2023

ColeHiggins2 requested a review from a team as a code owner November 29, 2023 15:21

vijaysawant requested changes Nov 30, 2023

View reviewed changes

tests/foreman/ui/test_repository.py Outdated Show resolved Hide resolved

tests/foreman/ui/test_repository.py Show resolved Hide resolved

vijaysawant approved these changes Dec 13, 2023

View reviewed changes

lhellebr approved these changes Dec 22, 2023

View reviewed changes

Gauravtalreja1 reviewed Jan 18, 2024

View reviewed changes

rplevka approved these changes Jan 26, 2024

View reviewed changes

ogajduse approved these changes Jan 26, 2024

View reviewed changes

tests/foreman/ui/test_repository.py Show resolved Hide resolved

ColeHiggins2 marked this pull request as draft February 2, 2024 14:09

ColeHiggins2 force-pushed the fixed_recommended_repo_test branch from 364d41c to 49f17a8 Compare February 5, 2024 20:43

ColeHiggins2 marked this pull request as ready for review February 5, 2024 20:54

ColeHiggins2 requested review from Gauravtalreja1 and ogajduse February 5, 2024 20:54

ColeHiggins2 added 6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 labels Feb 5, 2024

vijaysawant requested changes Feb 6, 2024

View reviewed changes

vijaysawant reviewed Feb 6, 2024

View reviewed changes

tests/foreman/ui/test_repository.py Show resolved Hide resolved

ColeHiggins2 added 5 commits February 12, 2024 13:46

adding fix to recommended repos test

ff7160e

addressing comments

27ae363

updating var names

6f0465b

change to module_sca_manifest_org

622de13

fixing build failure

c41b995

vijaysawant approved these changes Feb 13, 2024

View reviewed changes

Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Feb 13, 2024

sambible approved these changes Feb 13, 2024

View reviewed changes

Gauravtalreja1 approved these changes Feb 15, 2024

View reviewed changes

SatelliteQE deleted a comment from Satellite-QE Feb 15, 2024

ColeHiggins2 removed the 6.12.z Introduced in or relating directly to Satellite 6.12 label Feb 15, 2024

ColeHiggins2 marked this pull request as draft February 15, 2024 15:45

github-actions bot added the Stale Stale issue or Pull Request label Apr 1, 2024

github-actions bot removed the Stale Stale issue or Pull Request label Apr 9, 2024

github-actions bot added the Stale Stale issue or Pull Request label May 25, 2024

github-actions bot closed this Jun 1, 2024

[Test Fix] Updating Tools repo to Utils repo in the recommended repos test #13223

[Test Fix] Updating Tools repo to Utils repo in the recommended repos test #13223

Conversation

ColeHiggins2 commented Nov 29, 2023

vijaysawant left a comment • edited Loading

Choose a reason for hiding this comment

vijaysawant left a comment • edited Loading

Choose a reason for hiding this comment

lhellebr commented Dec 22, 2023

vijaysawant commented Jan 15, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vijaysawant Feb 6, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rplevka commented Jan 26, 2024

ogajduse left a comment

Choose a reason for hiding this comment

ColeHiggins2 commented Feb 5, 2024

vijaysawant left a comment

Choose a reason for hiding this comment

vijaysawant Feb 6, 2024 • edited Loading

Choose a reason for hiding this comment

vijaysawant commented Feb 13, 2024 • edited Loading

Satellite-QE commented Feb 13, 2024

Satellite-QE commented Feb 13, 2024

sambible commented Feb 13, 2024

sambible left a comment

Choose a reason for hiding this comment

Satellite-QE commented Feb 13, 2024

vijaysawant commented Feb 14, 2024

Satellite-QE commented Feb 14, 2024

Gauravtalreja1 left a comment

Choose a reason for hiding this comment

vsedmik commented Feb 15, 2024

Satellite-QE commented Feb 15, 2024

vsedmik commented Feb 15, 2024

vsedmik commented Feb 15, 2024

ColeHiggins2 commented Feb 15, 2024

Satellite-QE commented Feb 15, 2024

vsedmik commented Feb 15, 2024

Satellite-QE commented Feb 15, 2024

github-actions bot commented Apr 1, 2024

lhellebr commented Apr 8, 2024

github-actions bot commented May 25, 2024

github-actions bot commented Jun 1, 2024

vijaysawant left a comment •

edited

Loading

vijaysawant left a comment •

edited

Loading

vijaysawant Feb 6, 2024 •

edited

Loading

vijaysawant Feb 6, 2024 •

edited

Loading

vijaysawant commented Feb 13, 2024 •

edited

Loading