-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incremental update longrun 6 14 z #13286
Conversation
corrected target branch |
trigger: test-robottelo |
'environment_ids': [dev_lce.id], | ||
} | ||
], | ||
'add_content': {'errata_ids': [errata_list[0].id]}, | ||
} | ||
) | ||
# Re-read the content view to get the latest versions | ||
module_cv = module_cv.read() | ||
assert len(module_cv.version) > len(cv_versions) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain why this assertion is not good and is being removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
module_cv
was giving wrong cv version id in api call, It was giving previously published cvv id, hence I and @jyejare decided to remove it, as it was not much useful, we can acheive expected things in either ways.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong value of cv_version id ended up with failing entities.ContentViewVersion().incremental_update()
call, during debugging we found previous version id received at cv_versions[-1].id
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds like a bug/regression to me, shouldn't we report it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, there was reported BZ for unsorted cv version, In this test module we are ensuring api increamental update of applicable errata working fine without error, we are able to assert this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hope so I answered your query.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, pending answering the question about the removed assertion.
54e535a
to
ba703ce
Compare
fix for increamental update test scenario (cherry picked from commit 86bc15e)
Fix incremental update longrun 6 14 z (#13286) fix for increamental update test scenario (cherry picked from commit 86bc15e) Co-authored-by: vijay sawant <[email protected]>
Problem Statement
Hosts-Content > longrun > increamental update feature test was failing in 6.13.z & 6.14.z because content host unabled to install katello-host-tools
Error -
failed on setup with "robottelo.hosts.ContentHostError: Failed to install katello-host-tools"
Solution
Implemented changes which will solve said problem
Related Issues
Same problem has been seen in 6.13.z as well