Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incremental update longrun 6 14 z #13286

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

vijaysawant
Copy link
Contributor

Problem Statement

Hosts-Content > longrun > increamental update feature test was failing in 6.13.z & 6.14.z because content host unabled to install katello-host-tools

Error - failed on setup with "robottelo.hosts.ContentHostError: Failed to install katello-host-tools"

Solution

Implemented changes which will solve said problem

Related Issues

Same problem has been seen in 6.13.z as well

@vijaysawant vijaysawant added TestFailure Issues and PRs related to a test failing in automation No-CherryPick PR doesnt need CherryPick to previous branches 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 labels Dec 6, 2023
@vijaysawant vijaysawant requested review from a team as code owners December 6, 2023 13:39
@vijaysawant vijaysawant marked this pull request as draft December 6, 2023 13:40
@vijaysawant vijaysawant changed the base branch from master to 6.14.z December 6, 2023 13:54
@vijaysawant
Copy link
Contributor Author

corrected target branch

@vijaysawant vijaysawant marked this pull request as ready for review December 6, 2023 13:55
@vijaysawant
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/longrun/test_inc_updates.py -k test_positive_noapply_api

'environment_ids': [dev_lce.id],
}
],
'add_content': {'errata_ids': [errata_list[0].id]},
}
)
# Re-read the content view to get the latest versions
module_cv = module_cv.read()
assert len(module_cv.version) > len(cv_versions)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why this assertion is not good and is being removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

module_cv was giving wrong cv version id in api call, It was giving previously published cvv id, hence I and @jyejare decided to remove it, as it was not much useful, we can acheive expected things in either ways.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong value of cv_version id ended up with failing entities.ContentViewVersion().incremental_update() call, during debugging we found previous version id received at cv_versions[-1].id

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds like a bug/regression to me, shouldn't we report it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, there was reported BZ for unsorted cv version, In this test module we are ensuring api increamental update of applicable errata working fine without error, we are able to assert this change.

Copy link
Contributor Author

@vijaysawant vijaysawant Dec 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope so I answered your query.

Copy link
Contributor

@sambible sambible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, pending answering the question about the removed assertion.

@vijaysawant vijaysawant added CherryPick PR needs CherryPick to previous branches and removed No-CherryPick PR doesnt need CherryPick to previous branches labels Dec 8, 2023
@jameerpathan111 jameerpathan111 enabled auto-merge (squash) December 8, 2023 10:29
@vijaysawant vijaysawant force-pushed the fix_incremental_update_longrun-6_14_z branch from 54e535a to ba703ce Compare December 8, 2023 11:00
@jameerpathan111 jameerpathan111 merged commit 86bc15e into 6.14.z Dec 8, 2023
@jameerpathan111 jameerpathan111 deleted the fix_incremental_update_longrun-6_14_z branch December 8, 2023 11:09
github-actions bot pushed a commit that referenced this pull request Dec 8, 2023
fix for increamental update test scenario

(cherry picked from commit 86bc15e)
Gauravtalreja1 pushed a commit that referenced this pull request Dec 8, 2023
Fix incremental update longrun 6 14 z (#13286)

fix for increamental update test scenario

(cherry picked from commit 86bc15e)

Co-authored-by: vijay sawant <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 CherryPick PR needs CherryPick to previous branches TestFailure Issues and PRs related to a test failing in automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants