Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.14.z] Fix subnet tests #13293

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #13284

Problem Statement

After #12796, we identified a failure for one of negative tests is using invalid_missing_attributes dict to validate if subnet can be updated, after pytest.raises we're also validating if subnet isn't updated, there are invalid keys in use to check subnet key.

Solution

  1. Fixing the negative test with using exact values to check if subnet isn't updated with invalid values
  2. Updating tests to have the teardown
  3. Updating tests to use fauxfactory.gen_netmask instead of fixed netmasks

Related Issues

Signed-off-by: Gaurav Talreja <[email protected]>
(cherry picked from commit 8416dde)
@Satellite-QE Satellite-QE added 6.14.z Introduced in or relating directly to Satellite 6.14 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Dec 6, 2023
@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Dec 6, 2023
@Gauravtalreja1
Copy link
Collaborator

trigger: test-robottelo
pytest: tests/foreman/cli/test_subnet.py

@Satellite-QE Satellite-QE merged commit 6509e4d into 6.14.z Dec 6, 2023
22 checks passed
@Satellite-QE Satellite-QE deleted the cherry-pick-6.14.z-8416dde46893b7af1d76afe83ce24eab4a74ca96 branch December 6, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.14.z Introduced in or relating directly to Satellite 6.14 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants