Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.12.z] Update error message in negative settings test #13309

Merged
merged 1 commit into from
Dec 7, 2023
Merged

[6.12.z] Update error message in negative settings test #13309

merged 1 commit into from
Dec 7, 2023

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #13307

Problem Statement

After #12796, we identified a failure for this negative tests, where validation error message for foreman_url setting has changed

Solution

Updating validation error message for assertion, and removing unnecessary parametrization over entries_per_page

Related Issues

SatelliteQE/airgun#1064

@Satellite-QE Satellite-QE added 6.12.z Introduced in or relating directly to Satellite 6.12 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Dec 7, 2023
@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Dec 7, 2023
@Gauravtalreja1
Copy link
Collaborator

trigger: test-robottelo
pytest: tests/foreman/ui/test_settings.py -k test_negative_validate_foreman_url_error_message
airgun: 1064

@Gauravtalreja1
Update error message in negative settings test (#13307)
48a90ae 
Signed-off-by: Gaurav Talreja <[email protected]>
(cherry picked from commit 9af01c7)
@Gauravtalreja1 Gauravtalreja1 force-pushed the cherry-pick-6.12.z-9af01c78c98e5afcd5c13540ea2f4e2c5dc0c64d branch from d541520 to 48a90ae Compare December 7, 2023 13:57
@Gauravtalreja1
Copy link
Collaborator

trigger: test-robottelo
pytest: tests/foreman/ui/test_settings.py -k test_negative_validate_foreman_url_error_message

@Gauravtalreja1 Gauravtalreja1 merged commit 807e8bb into 6.12.z Dec 7, 2023
6 checks passed
@Gauravtalreja1 Gauravtalreja1 deleted the cherry-pick-6.12.z-9af01c78c98e5afcd5c13540ea2f4e2c5dc0c64d branch December 7, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColeHiggins2 ColeHiggins2 ColeHiggins2 approved these changes

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

Assignees

@Gauravtalreja1 Gauravtalreja1

Labels
6.12.z Introduced in or relating directly to Satellite 6.12 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Satellite-QE @Gauravtalreja1 @ColeHiggins2