Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed api audit tests #13368

Merged
merged 1 commit into from
Dec 11, 2023
Merged

fixed api audit tests #13368

merged 1 commit into from
Dec 11, 2023

Conversation

pondrejk
Copy link
Contributor

Problem Statement

#12989 swapped entities for target_sat.api, but:

ent = entities.Architecture()
ent.__class__.__name__.lower()
'architecture'

ent_new = target_sat.api.Architecture()
ent_new.__class__.__name__.lower()
'decclass'

Hence test failures

Solution

made the search type explicit, not too happy about test not reusing the same data but went for the fast solution with component evaluation in sight for this one

@pondrejk pondrejk added TestFailure Issues and PRs related to a test failing in automation CherryPick PR needs CherryPick to previous branches 6.12.z Introduced in or relating directly to Satellite 6.12 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Dec 11, 2023
@pondrejk pondrejk self-assigned this Dec 11, 2023
@pondrejk pondrejk requested a review from a team as a code owner December 11, 2023 14:38
@pondrejk
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_audit.py

JacobCallahan
JacobCallahan approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@JacobCallahan JacobCallahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, great find!

sambible
sambible approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@sambible sambible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@sambible sambible merged commit 2809bdb into SatelliteQE:master Dec 11, 2023
13 checks passed
This was referenced Dec 11, 2023
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sambible sambible sambible approved these changes

@JacobCallahan JacobCallahan JacobCallahan approved these changes

Assignees

@pondrejk pondrejk

Labels
6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches TestFailure Issues and PRs related to a test failing in automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pondrejk @JacobCallahan @sambible