Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.14.z] Get rid of deprecated mirror-on-sync #13472

Merged
merged 1 commit into from
Dec 15, 2023
Merged

[6.14.z] Get rid of deprecated mirror-on-sync #13472

merged 1 commit into from
Dec 15, 2023

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #13425

Problem Statement

mirror-on-sync was deprecated and replaced by mirroring-policy in Katello 4.8.0 (see https://projects.theforeman.org/issues/36140)

However, it seems there are last two remaining occurrences in robottelo which need to be updated if we don't wish to see errors like this:

Command "repository create" finished with status 64
stderr contains:
Could not create the repository:
  Error: Unrecognised option '--mirror-on-sync'.

Solution

Get rid of the deprecated mirror-on-sync option.

@Satellite-QE Satellite-QE added 6.14.z Introduced in or relating directly to Satellite 6.14 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Dec 15, 2023
@Satellite-QE
Copy link
Collaborator Author 

trigger: test-robottelo
pytest: tests/foreman/cli/test_satellitesync.py -k test_positive_export_import_cv_end_to_end
env:
  ROBOTTELO_server__deploy_arguments__deploy_rhel_version: '8.9'
  ROBOTTELO_server__deploy_arguments__deploy_sat_version: 'stream'
  ROBOTTELO_server__deploy_arguments__deploy_snap_version: '39.0'

@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Dec 15, 2023
@Gauravtalreja1
Copy link
Collaborator

trigger: test-robottelo
pytest: tests/foreman/cli/test_satellitesync.py -k test_positive_export_import_cv_end_to_end

@Gauravtalreja1 Gauravtalreja1 merged commit 1bcfcdf into 6.14.z Dec 15, 2023
21 of 22 checks passed
@Gauravtalreja1 Gauravtalreja1 deleted the cherry-pick-6.14.z-0452011e7ba6e6cf5499b3520883405425eb1786 branch December 15, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

Assignees

@vsedmik vsedmik

Labels
6.14.z Introduced in or relating directly to Satellite 6.14 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Satellite-QE @Gauravtalreja1 @vsedmik