Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove the unused testimony tokens & none used for reporting #13479

Merged
merged 1 commit into from
Jan 8, 2024
Merged

remove the unused testimony tokens & none used for reporting #13479

merged 1 commit into from
Jan 8, 2024

Conversation

omkarkhatavkar
Copy link

Problem Statement

Remove 3 tokens from Robottelo which are not useful or not being used anywhere in reporting:

TestType
Upstream
CaseLevel

Solution

removed these three token from the test docstring, This will need some testing against Polarian staging host.

@omkarkhatavkar omkarkhatavkar requested review from a team as code owners December 17, 2023 16:16
@omkarkhatavkar omkarkhatavkar force-pushed the dump_unused_testimony_tokens branch from 55a2b27 to a3f0b08 Compare December 17, 2023 16:19
@omkarkhatavkar omkarkhatavkar added CherryPick PR needs CherryPick to previous branches 6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Dec 17, 2023
@omkarkhatavkar omkarkhatavkar force-pushed the dump_unused_testimony_tokens branch 4 times, most recently from 2f778dc to 1ce7e33 Compare December 18, 2023 08:53
@omkarkhatavkar
Copy link
Author

"trigger": "test-robottelo"

JacobCallahan
JacobCallahan requested changes Dec 19, 2023
View reviewed changes
@omkarkhatavkar omkarkhatavkar force-pushed the dump_unused_testimony_tokens branch 5 times, most recently from 771e7ba to 07a6c1c Compare December 20, 2023 14:36
@omkarkhatavkar omkarkhatavkar force-pushed the dump_unused_testimony_tokens branch 2 times, most recently from deb3a1b to 8126c1b Compare December 20, 2023 14:58
@omkarkhatavkar
Copy link
Author

"trigger": "test-robottelo"

JacobCallahan
JacobCallahan requested changes Dec 20, 2023
View reviewed changes
Copy link
Member

@JacobCallahan JacobCallahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting very close!

@omkarkhatavkar omkarkhatavkar force-pushed the dump_unused_testimony_tokens branch from 8126c1b to 2d71e81 Compare December 21, 2023 06:52
@omkarkhatavkar
Copy link
Author

omkarkhatavkar commented Dec 21, 2023 •
edited
Loading

Verified Test XML Result

image

JacobCallahan
JacobCallahan approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@JacobCallahan JacobCallahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, well done!!

@omkarkhatavkar
Copy link
Author

trigger: test-robottelo

1 similar comment
@omkarkhatavkar
Copy link
Author

trigger: test-robottelo

@omkarkhatavkar omkarkhatavkar force-pushed the dump_unused_testimony_tokens branch from 88bfa06 to 303dd66 Compare January 8, 2024 07:24
@omkarkhatavkar
Copy link
Author

trigger: test-robottelo

@jyejare jyejare force-pushed the dump_unused_testimony_tokens branch from 303dd66 to 77e81b0 Compare January 8, 2024 13:19
@jyejare jyejare enabled auto-merge (squash) January 8, 2024 13:19
@omkarkhatavkar omkarkhatavkar force-pushed the dump_unused_testimony_tokens branch 2 times, most recently from aa99cb1 to 0050f0f Compare January 8, 2024 14:21
@dependabot @omkarkhatavkar
Bump flake8 from 6.1.0 to 7.0.0
a8125f0 
Bumps [flake8](https://github.com/pycqa/flake8) from 6.1.0 to 7.0.0.
- [Commits](PyCQA/flake8@6.1.0...7.0.0)

---
updated-dependencies:
- dependency-name: flake8
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@omkarkhatavkar omkarkhatavkar force-pushed the dump_unused_testimony_tokens branch from 0050f0f to a8125f0 Compare January 8, 2024 15:04
@jyejare jyejare merged commit 14cdcc2 into SatelliteQE:master Jan 8, 2024
This was referenced Jan 8, 2024
Closed
Closed
Closed
Closed
omkarkhatavkar added a commit to omkarkhatavkar/robottelo that referenced this pull request Jan 9, 2024
@omkarkhatavkar @dependabot
remove the unused testimony tokens & none used for reporting (Satelli…
d86b996 
…teQE#13479)

Bump flake8 from 6.1.0 to 7.0.0

Bumps [flake8](https://github.com/pycqa/flake8) from 6.1.0 to 7.0.0.
- [Commits](PyCQA/flake8@6.1.0...7.0.0)

---
updated-dependencies:
- dependency-name: flake8
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@omkarkhatavkar omkarkhatavkar mentioned this pull request Jan 9, 2024
Merged
omkarkhatavkar added a commit to omkarkhatavkar/robottelo that referenced this pull request Jan 9, 2024
@omkarkhatavkar @dependabot
remove the unused testimony tokens & none used for reporting (Satelli…
f9e2bdf 
…teQE#13479)

Bump flake8 from 6.1.0 to 7.0.0

Bumps [flake8](https://github.com/pycqa/flake8) from 6.1.0 to 7.0.0.
- [Commits](PyCQA/flake8@6.1.0...7.0.0)

---
updated-dependencies:
- dependency-name: flake8
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
omkarkhatavkar added a commit to omkarkhatavkar/robottelo that referenced this pull request Jan 9, 2024
@omkarkhatavkar @dependabot
remove the unused testimony tokens & none used for reporting (Satelli…
5764537 
…teQE#13479)

Bump flake8 from 6.1.0 to 7.0.0

Bumps [flake8](https://github.com/pycqa/flake8) from 6.1.0 to 7.0.0.
- [Commits](PyCQA/flake8@6.1.0...7.0.0)

---
updated-dependencies:
- dependency-name: flake8
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
omkarkhatavkar added a commit to omkarkhatavkar/robottelo that referenced this pull request Jan 9, 2024
@omkarkhatavkar @dependabot
remove the unused testimony tokens & none used for reporting (Satelli…
cc90c8f 
…teQE#13479)

Bump flake8 from 6.1.0 to 7.0.0

Bumps [flake8](https://github.com/pycqa/flake8) from 6.1.0 to 7.0.0.
- [Commits](PyCQA/flake8@6.1.0...7.0.0)

---
updated-dependencies:
- dependency-name: flake8
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@omkarkhatavkar omkarkhatavkar mentioned this pull request Jan 9, 2024
Closed
omkarkhatavkar added a commit to omkarkhatavkar/robottelo that referenced this pull request Jan 9, 2024
@omkarkhatavkar @dependabot
remove the unused testimony tokens & none used for reporting (Satelli…
da14793 
…teQE#13479)

Bump flake8 from 6.1.0 to 7.0.0

Bumps [flake8](https://github.com/pycqa/flake8) from 6.1.0 to 7.0.0.
- [Commits](PyCQA/flake8@6.1.0...7.0.0)

---
updated-dependencies:
- dependency-name: flake8
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
omkarkhatavkar added a commit to omkarkhatavkar/robottelo that referenced this pull request Jan 10, 2024
@omkarkhatavkar @dependabot
remove the unused testimony tokens & none used for reporting (Satelli…
ca6673c 
…teQE#13479)

Bump flake8 from 6.1.0 to 7.0.0

Bumps [flake8](https://github.com/pycqa/flake8) from 6.1.0 to 7.0.0.
- [Commits](PyCQA/flake8@6.1.0...7.0.0)

---
updated-dependencies:
- dependency-name: flake8
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
jyejare pushed a commit that referenced this pull request Jan 10, 2024
@omkarkhatavkar @dependabot
[6.15.z] - remove the unused testimony tokens & none used for reporti…
7c4ec5c 
…ng (#13479) (#13667)

remove the unused testimony tokens & none used for reporting (#13479)

Bump flake8 from 6.1.0 to 7.0.0

Bumps [flake8](https://github.com/pycqa/flake8) from 6.1.0 to 7.0.0.
- [Commits](PyCQA/flake8@6.1.0...7.0.0)

---
updated-dependencies:
- dependency-name: flake8
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Jan 11, 2024
Merged
Merged
omkarkhatavkar added a commit to omkarkhatavkar/robottelo that referenced this pull request Mar 14, 2024
@omkarkhatavkar
remove the unused testimony tokens & none used for reporting (Satelli…
3075e87 
…teQE#13479)
@omkarkhatavkar omkarkhatavkar mentioned this pull request Mar 14, 2024
Merged
Gauravtalreja1 pushed a commit that referenced this pull request Mar 14, 2024
@omkarkhatavkar
[6.12.z] - remove the unused testimony tokens & none used for reporti…
d2c9731 
…ng (#13479) (#14414)

remove the unused testimony tokens & none used for reporting (#13479)
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
@omkarkhatavkar @dependabot @shweta83
remove the unused testimony tokens & none used for reporting (Satelli…
a68200b 
…teQE#13479)

Bump flake8 from 6.1.0 to 7.0.0

Bumps [flake8](https://github.com/pycqa/flake8) from 6.1.0 to 7.0.0.
- [Commits](PyCQA/flake8@6.1.0...7.0.0)

---
updated-dependencies:
- dependency-name: flake8
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobCallahan JacobCallahan JacobCallahan approved these changes

@jyejare jyejare jyejare approved these changes

Assignees

@omkarkhatavkar omkarkhatavkar

Labels
6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@omkarkhatavkar @jyejare @JacobCallahan