Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for fapolicyd installation #13488

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Add test for fapolicyd installation #13488

merged 1 commit into from
Jan 4, 2024

Conversation

jameerpathan111
Copy link
Contributor

@jameerpathan111 jameerpathan111 commented Dec 18, 2023 •
edited
Loading

Problem Statement

Missing test coverage for Satellite and Capsule installation with fapolicyd

Solution

Update existing test for fapolicyd

Related Issues

@jameerpathan111 jameerpathan111 added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.15.z Introduced in or relating directly to Satellite 6.15 labels Dec 18, 2023
@jameerpathan111 jameerpathan111 self-assigned this Dec 18, 2023
@jameerpathan111 jameerpathan111 requested review from a team as code owners December 18, 2023 14:20
@jameerpathan111
Copy link
Contributor Author

jameerpathan111 commented Dec 18, 2023 •
edited
Loading

trigger: test-robottelo
pytest: tests/foreman/installer/test_installer.py

JacobCallahan
JacobCallahan requested changes Dec 18, 2023
View reviewed changes
Copy link
Member

@JacobCallahan JacobCallahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! Just some small suggestions.

tests/foreman/installer/test_installer.py Outdated Show resolved Hide resolved
robottelo/hosts.py Outdated Show resolved Hide resolved
@jameerpathan111 jameerpathan111 force-pushed the fapolicyd branch 2 times, most recently from 6d81fc6 to 3cbabed Compare December 19, 2023 05:37
@jameerpathan111
Copy link
Contributor Author

jameerpathan111 commented Dec 19, 2023 •
edited
Loading 

trigger: test-robottelo
pytest: tests/foreman/installer/test_installer.py -k test_capsule_installation
env:
   ROBOTTELO_server__deploy_arguments__deploy_rhel_version: '8'
   ROBOTTELO_server__deploy_arguments__deploy_sat_version: 'stream'
   ROBOTTELO_server__deploy_arguments__deploy_snap_version: '42'

@jameerpathan111 jameerpathan111 force-pushed the fapolicyd branch 2 times, most recently from 71be459 to 8b49310 Compare December 19, 2023 11:36
JacobCallahan
JacobCallahan approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@JacobCallahan JacobCallahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK on the contents. However, can you look into the PRT failures and determine the causes? I'm hoping the connection timeout isn't related to enabling fapolicyd.

@jameerpathan111 jameerpathan111 force-pushed the fapolicyd branch 9 times, most recently from 59c0412 to 558424f Compare December 22, 2023 12:30
@JacobCallahan
Copy link
Member

trigger: test-robottelo
pytest: tests/foreman/installer/test_installer.py -k test_capsule_installation
env:
ROBOTTELO_server__deploy_arguments__deploy_rhel_version: '8'
ROBOTTELO_server__deploy_arguments__deploy_sat_version: 'stream'
ROBOTTELO_server__deploy_arguments__deploy_snap_version: '42'

@jameerpathan111 jameerpathan111 force-pushed the fapolicyd branch 2 times, most recently from 9fb008b to f17330a Compare January 3, 2024 06:14
@jameerpathan111
Copy link
Contributor Author

jameerpathan111 commented Jan 3, 2024 •
edited
Loading 

trigger: test-robottelo
pytest: tests/foreman/installer/test_installer.py -k test_capsule_installation
env:
   ROBOTTELO_server__deploy_arguments__deploy_rhel_version: '8'
   ROBOTTELO_server__deploy_arguments__deploy_sat_version: 'stream'
   ROBOTTELO_server__deploy_arguments__deploy_snap_version: '42'

@omkarkhatavkar omkarkhatavkar merged commit 963700e into SatelliteQE:master Jan 4, 2024
6 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 4, 2024
@jameerpathan111 @web-flow
Add test for fapolicyd installation (#13488)
00478ac 
Update tests to cover fapolicyd installation

(cherry picked from commit 963700e)
@Satellite-QE Satellite-QE mentioned this pull request Jan 4, 2024
Merged
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
@jameerpathan111 @shweta83
Add test for fapolicyd installation (SatelliteQE#13488)
a8ce5e0 
Update tests to cover fapolicyd installation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobCallahan JacobCallahan JacobCallahan approved these changes

@omkarkhatavkar omkarkhatavkar omkarkhatavkar approved these changes

Assignees

@jameerpathan111 jameerpathan111

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jameerpathan111 @JacobCallahan @omkarkhatavkar