Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add coverage for BZ#2112098 #13506

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Add coverage for BZ#2112098 #13506

merged 2 commits into from
Jan 8, 2024

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented Dec 19, 2023

Problem Statement

  1. Custom CDN with custom ContentCredential scenario is still missing.
  2. Misleading name of one fixture.

Solution

  1. Add new test case to cover Custom CDN with CC.
  2. Rename the fixture.

Related Issues

https://bugzilla.redhat.com/show_bug.cgi?id=2112098

@vsedmik vsedmik added CLI Issues and PRs involving the CLI QETestCoverage Issues and PRs relating to a Satellite bug CherryPick PR needs CherryPick to previous branches 6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Dec 19, 2023
@vsedmik vsedmik self-assigned this Dec 19, 2023
@vsedmik vsedmik requested review from a team as code owners December 19, 2023 16:43
@vsedmik
Copy link
Contributor Author

vsedmik commented Dec 19, 2023

trigger: test-robottelo
pytest: tests/foreman/cli/test_satellitesync.py -k test_positive_custom_cdn_with_credential

@vsedmik vsedmik force-pushed the iss-custom-cdn branch 2 times, most recently from b38f44f to 268d132 Compare December 19, 2023 16:53
@vsedmik
Copy link
Contributor Author

vsedmik commented Dec 19, 2023

trigger: test-robottelo
pytest: tests/foreman/cli/test_satellitesync.py -k test_positive_custom_cdn_with_credential

damoore044
damoore044 approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@damoore044 damoore044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack 👍

@vsedmik
Copy link
Contributor Author

vsedmik commented Dec 21, 2023

trigger: test-robottelo
pytest: tests/foreman/cli/test_satellitesync.py -k test_positive_custom_cdn_with_credential

@vsedmik
Copy link
Contributor Author

vsedmik commented Jan 2, 2024

Updated fixture name for recently merged case (#13543), rebased.

@pondrejk pondrejk merged commit 6ca5aae into SatelliteQE:master Jan 8, 2024
This was referenced Jan 8, 2024
Closed
Closed
Closed
Closed
This was referenced Jan 9, 2024
Merged
Merged
This was referenced Jan 9, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhellebr lhellebr lhellebr approved these changes

@pondrejk pondrejk pondrejk approved these changes

@damoore044 damoore044 damoore044 approved these changes

Assignees

@vsedmik vsedmik

Labels
6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 CherryPick PR needs CherryPick to previous branches CLI Issues and PRs involving the CLI QETestCoverage Issues and PRs relating to a Satellite bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vsedmik @lhellebr @pondrejk @damoore044