-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CompEval] API modifications for errata-management #13515
Conversation
d2ae8da
to
efcb401
Compare
Last Build [5430] vs 6.15.0 CI - Jan 18, 2024, 2:17 PMPass: 12 [+6] Total: 12 vs 15 (3 sorting tests were merged into
|
9166aca
to
1e8c7c0
Compare
3eefd9b
to
bb18a48
Compare
2f8c308
to
5951402
Compare
5951402
to
a675260
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few other things
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few suggestions only, no blocker.
5740154
to
6c4c990
Compare
2977293
to
5632656
Compare
@damoore044 If the test failure is due to product changes, feel free to remove it and for the negative test that you wanted to do, add a new test for it! This way in reporting tools new test will be removed and new tests would be added with unique id! Also, the change is applicable for all zstream versions ? if yes, please raise a separate PR for this change and we will merge this PR with single failure :) |
5632656
to
9ae05b0
Compare
@jyejare From discussing with the QE team, we can remove this outdated test |
9ae05b0
to
f3f059b
Compare
@jyejare From local testing, this MR will be good to cherry-pick into 6.15.z, 6.14.z. |
@damoore044 agree with merging this PR with removing that test case. Also add cherrypick labels for branches and a cherrypick label itself for auto CP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, in PRT all tests passed. Left just one non-blocking nitpick comment but I think we are good to merge.
Good work @damoore044!
pre-commit fix
verify key exists in task, prior to accessing
f3f059b
to
1f92fab
Compare
trigger: test-robottelo |
* api-errata-updates, component-eval, global registration and host content * Combine the list, sort, and filter tests * Add CU scenario for puma worker count pre-commit fix * Docstring fixes verify key exists in task, prior to accessing * Remove outdated Default_CV scenario --------- Co-authored-by: Griffin Sullivan <[email protected]> (cherry picked from commit 48dc4d0)
* api-errata-updates, component-eval, global registration and host content * Combine the list, sort, and filter tests * Add CU scenario for puma worker count pre-commit fix * Docstring fixes verify key exists in task, prior to accessing * Remove outdated Default_CV scenario --------- Co-authored-by: Griffin Sullivan <[email protected]>
Problem Statement
API errata has several outdated tests to be modified, combined, or removed for component evaluation.
8-12 consistent failures in 6.15.0 CI, most in setup of hosts, errata/packages, or necessary components.
Solution
Updated hosts to register with global registration.
rhel8 hosts using rh repos and packages for rhel8,
setup_content
fixture now using the same.Combine the following view, sort, and filter scenarios per comp-eval, into just
test_positive_list_sorted_filtered
:test_positive_list
-test_positive_list_updated
-test_positive_sorted_issue_date_and_filter_by_cve
Helper method to api publish & promote a content-view,
wait for task(s) after
content-view.publish()
Fix
api_factory
methodwait_for_errata_applicability_task
, which was using an old search format to find applicability tasks.Propose marking the following as an End-to-End test, as it touches all components needed for errata,
and performs a common and critical customer use-case; of installing errata to hosts in host collection:
test_positive_install_in_hc[rhel params for 7, 8, 9]
test_apply_modular_errata_using_default_content_view
: Removed this outdated test case-as the DefaultCV cannot be edited, published, promoted etc. A follow up introduction could cover this
with a test_negative scenario.
Prior Failures - Resolved
test_errata_installation_with_swidtags
: Unsure if we can use some othermodule_repos_collection
,that does not touch
module_entitlement_manifest_org
? output below :Passing, I made a new fixture:
function_repos_collection_with_manifest
infixtures>repository.py
, usingfunction_sca_manifest_org
.PRT Case