[6.14.z] extra check not recording property incase of video recording is false #13564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Satellite-QE
added
6.14.z
Gauravtalreja1
approved these changes
Dec 27, 2023
Gauravtalreja1
deleted the
cherry-pick-6.14.z-61219a18502cbd082d5f9bf486707c68fa083967
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherrypick of PR: #13475
Problem Statement
Currently, every time we record a video URL is a JUnit report, which is not necessary in case the video recording is false.
Solution
Adding extra layer check to see record_property is not null and video recording is true