Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Customer Case] Adding test for overriding repos no select all #13596

Merged
merged 3 commits into from
Feb 6, 2024
Merged

[Customer Case] Adding test for overriding repos no select all #13596

merged 3 commits into from
Feb 6, 2024

Conversation

ColeHiggins2
Copy link
Member

Adding customer case automation for overriding repos without using the select all method

@ColeHiggins2 ColeHiggins2 added CherryPick PR needs CherryPick to previous branches 6.15.z Introduced in or relating directly to Satellite 6.15 labels Jan 3, 2024
@ColeHiggins2 ColeHiggins2 self-assigned this Jan 3, 2024
@ColeHiggins2 ColeHiggins2 requested a review from a team as a code owner January 3, 2024 21:34
@ColeHiggins2 ColeHiggins2 marked this pull request as draft January 3, 2024 21:34
@ColeHiggins2 ColeHiggins2 mentioned this pull request Jan 4, 2024
Merged
@ColeHiggins2
Copy link
Member Author

airgun: SatelliteQE/airgun#1120

@Satellite-QE Satellite-QE mentioned this pull request Jan 9, 2024
Merged
@Gauravtalreja1
Copy link
Collaborator

@ColeHiggins2 could you fix failing pre-commit checks and run PRT for this test?

@ColeHiggins2
Copy link
Member Author

Keeping in draft until upstream fix is in downstream

@ColeHiggins2 ColeHiggins2 force-pushed the override_multiple_repos branch from fcaa141 to 0867471 Compare January 18, 2024 18:27
@ColeHiggins2 ColeHiggins2 marked this pull request as ready for review January 18, 2024 18:27
@ColeHiggins2
Copy link
Member Author

Opening up and ready for review

sambible
sambible approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@sambible sambible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK pending PRT, looks good.

@sambible
Copy link
Contributor

trigger: test-robottelo
pytest: tests/foreman/ui/test_repositories.py -k 'test_positive_override_custom_products_using_select_all'

@ColeHiggins2
Copy link
Member Author

Looking into adding 6.14 label. DO not merge until response

vijaysawant
vijaysawant requested changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@vijaysawant vijaysawant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested simple changes.

tests/foreman/ui/test_repositories.py Outdated Show resolved Hide resolved
tests/foreman/ui/test_repositories.py Outdated Show resolved Hide resolved
tests/foreman/ui/test_repositories.py Outdated Show resolved Hide resolved
tests/foreman/ui/test_repositories.py Outdated Show resolved Hide resolved
ogajduse
ogajduse approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@ogajduse ogajduse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK - Reviewed mainly from the framework PoV.

@ColeHiggins2 Can you please act on @vijaysawant's review comments?

@ColeHiggins2 ColeHiggins2 force-pushed the override_multiple_repos branch from 0867471 to 63ae6e7 Compare February 5, 2024 19:02
@ColeHiggins2
Copy link
Member Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_repositories.py -k 'test_positive_override_custom_products_using_select_all'

vijaysawant
vijaysawant reviewed Feb 6, 2024
View reviewed changes
Copy link
Contributor

@vijaysawant vijaysawant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, all comments addressed.
PRT is also passing.

@vijaysawant vijaysawant merged commit 3ed7881 into SatelliteQE:master Feb 6, 2024
6 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 6, 2024
@ColeHiggins2 @web-flow
[Customer Case] Adding test for overriding repos no select all (#13596)
caf2504 
* Adding test for overriding repos no select all

* fixing pre-commit

* addressing comments

(cherry picked from commit 3ed7881)
@Satellite-QE Satellite-QE mentioned this pull request Feb 6, 2024
Merged
Gauravtalreja1 pushed a commit that referenced this pull request Feb 7, 2024
@Satellite-QE @ColeHiggins2
[6.15.z] [Customer Case] Adding test for overriding repos no select a…
981efcd 
…ll (#13996)

[Customer Case] Adding test for overriding repos no select all (#13596)

* Adding test for overriding repos no select all

* fixing pre-commit

* addressing comments

(cherry picked from commit 3ed7881)

Co-authored-by: Cole Higgins <[email protected]>
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
@ColeHiggins2 @shweta83
[Customer Case] Adding test for overriding repos no select all (Satel…
bb77940 
…liteQE#13596)

* Adding test for overriding repos no select all

* fixing pre-commit

* addressing comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vijaysawant vijaysawant vijaysawant approved these changes

@ogajduse ogajduse ogajduse approved these changes

@sambible sambible sambible approved these changes

Assignees

@ColeHiggins2 ColeHiggins2

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 CherryPick PR needs CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ColeHiggins2 @Gauravtalreja1 @sambible @ogajduse @vijaysawant