Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

global registration with nested hostgroup #13617

Merged
merged 1 commit into from
Feb 28, 2024
Merged

global registration with nested hostgroup #13617

merged 1 commit into from
Feb 28, 2024

Conversation

pondrejk
Copy link
Contributor

@pondrejk pondrejk commented Jan 5, 2024

Problem Statement

Applying the component evaluation feedback to cover 1955421

Solution

Adding a nested hostgroup to the global registration test to check the values are populated correctly

@pondrejk pondrejk added CherryPick PR needs CherryPick to previous branches 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Jan 5, 2024
@pondrejk pondrejk self-assigned this Jan 5, 2024
@pondrejk pondrejk requested a review from a team as a code owner January 5, 2024 11:01
@pondrejk
Copy link
Contributor Author

pondrejk commented Jan 5, 2024

trigger: test-robottelo
pytest: tests/foreman/ui/test_host.py -k global_registration_form_populate

2 similar comments
@pondrejk
Copy link
Contributor Author

pondrejk commented Jan 5, 2024

trigger: test-robottelo
pytest: tests/foreman/ui/test_host.py -k global_registration_form_populate

@pondrejk
Copy link
Contributor Author

pondrejk commented Jan 8, 2024

trigger: test-robottelo
pytest: tests/foreman/ui/test_host.py -k global_registration_form_populate

@pnovotny
Copy link
Contributor

pnovotny commented Jan 8, 2024

The test update looks good, although the PRT failed on:
ERROR - [HostRegisterView/general]: FormSelect('.//*[contains(@data-ouia-component-type,"PF4/FormSelect") and @data-ouia-component-id="reg_host_group"]') is not enabled

Maybe a timing or widget issue?

@pondrejk
Copy link
Contributor Author

pondrejk commented Feb 7, 2024

just bumping, there is a an issue on the airgun side being worked on, will re-run tests when ready

@Gauravtalreja1
Copy link
Collaborator

@pondrejk Could you rebase this PR over #13450, and resolve conflicts?

@pondrejk
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_registration.py -k global_registration_form_populate
airgun: 1226

@pondrejk pondrejk added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Feb 27, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 5864
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_registration.py -k global_registration_form_populate
Test Result : ========== 1 passed, 12 deselected, 13 warnings in 772.29s (0:12:52) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Feb 27, 2024
@pondrejk pondrejk mentioned this pull request Feb 27, 2024
Merged
@pondrejk
Copy link
Contributor Author

@Gauravtalreja1 @pnovotny rebased, prt passing

@Gauravtalreja1 Gauravtalreja1 added the QETestCoverage Issues and PRs relating to a Satellite bug label Feb 28, 2024
@Gauravtalreja1 Gauravtalreja1 merged commit 89c80a3 into SatelliteQE:master Feb 28, 2024
10 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 28, 2024
@pondrejk @web-flow
global registration with nested hostgroup (#13617)
3a21cec 
(cherry picked from commit 89c80a3)
@Satellite-QE Satellite-QE mentioned this pull request Feb 28, 2024
Closed
github-actions bot pushed a commit that referenced this pull request Feb 28, 2024
@pondrejk @web-flow
global registration with nested hostgroup (#13617)
59a669a 
(cherry picked from commit 89c80a3)
@Satellite-QE Satellite-QE mentioned this pull request Feb 28, 2024
Merged
pondrejk added a commit that referenced this pull request Mar 19, 2024
@pondrejk
global registration with nested hostgroup (#13617)
af09235 
(cherry picked from commit 89c80a3)
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
@pondrejk @shweta83
global registration with nested hostgroup (SatelliteQE#13617)
1a09c27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LadislavVasina1 LadislavVasina1 LadislavVasina1 approved these changes

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

Assignees

@pondrejk pondrejk

Labels
6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR QETestCoverage Issues and PRs relating to a Satellite bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pondrejk @pnovotny @Gauravtalreja1 @Satellite-QE @LadislavVasina1