-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[6.15 RFE] Prepare for sca only hammer 6.15 #13627
[6.15 RFE] Prepare for sca only hammer 6.15 #13627
Conversation
trigger: test-robottelo |
in str(org_results.stderr) | ||
) | ||
sca_results = target_sat.execute( | ||
f'hammer simple-content-access disable --organization-id {function_org.id}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we update it to use robottelo cli method SimpleContentAccess.disable()?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Gauravtalreja1 simplecontentaccess.disable() just returns an empty string. I cannot get the required output message unless I pull from robottelo.log
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ColeHiggins2 as you need to verify output from command's stderr, and you're not able to use cli.SimpleContentAccess for this because of ignore_stderr=True
argument, you could remove it from here and update the PR for the same https://github.com/SatelliteQE/robottelo/blob/master/robottelo/cli/simple_content_access.py#L33
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
will be required for all organizations in the next release | ||
""" | ||
org_results = target_sat.execute( | ||
f'hammer organization update --id {function_org.id} --simple-content-access false' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this be updated to use Org CLI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasnt able to pull the pull the text "Simple Content Access will be required for all organizations in the next release" from target_sat.cli.Org.update() ... only Organization updated. I think its fine as is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ColeHiggins2 okay, could we not update this as similar to target_sat.cli.SimpleContentAccess.disable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we cannot use target_sat.cli.SimpleContentAccess.disable. that uses the simple-content-access cli command not the organization command. for example:
hammer simple-content-access disable ...
vs
hammer organization update ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ColeHiggins2 i think @Gauravtalreja1's suggestion here is to update the target_sat.cli.Org.update
method to also be able to give you the raw output. Then you could check stdout and stderr content from there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
605794d
to
fa5fa57
Compare
trigger: test-robottelo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
6.15 Features automation: SAT-20202
This test is verifying that hammer notifies users that Simple Content Access will be required for all organizations in the next release
copy of #12963