Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fix for SyncPlan test #13661

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Small fix for SyncPlan test #13661

merged 1 commit into from
Jan 8, 2024

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented Jan 8, 2024

Problem Statement

Probably overlooked in #11544.

Solution

Syntax fix.

@vsedmik vsedmik added CherryPick PR needs CherryPick to previous branches 6.12.z Introduced in or relating directly to Satellite 6.12 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Jan 8, 2024
@vsedmik vsedmik requested a review from a team as a code owner January 8, 2024 20:06
@vsedmik vsedmik self-assigned this Jan 8, 2024
@vsedmik
Copy link
Contributor Author

vsedmik commented Jan 8, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_syncplan.py -k test_positive_info_with_assigned_product

sambible
sambible approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@sambible sambible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ( Tempted to just slam it in tbh, but I'll let someone else have a look :) )

@Griffin-Sullivan Griffin-Sullivan merged commit 07fa9bc into SatelliteQE:master Jan 8, 2024
12 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 8, 2024
@vsedmik @web-flow
Small fix for SyncPlan test (#13661)
8ba2227 
(cherry picked from commit 07fa9bc)
@Satellite-QE Satellite-QE mentioned this pull request Jan 8, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Jan 8, 2024
@vsedmik @web-flow
Small fix for SyncPlan test (#13661)
2b7526e 
(cherry picked from commit 07fa9bc)
github-actions bot pushed a commit that referenced this pull request Jan 8, 2024
@vsedmik @web-flow
Small fix for SyncPlan test (#13661)
cebde94 
(cherry picked from commit 07fa9bc)
This was referenced Jan 8, 2024
Merged
Merged
github-actions bot pushed a commit that referenced this pull request Jan 8, 2024
@vsedmik @web-flow
Small fix for SyncPlan test (#13661)
edf14ed 
(cherry picked from commit 07fa9bc)
@Satellite-QE Satellite-QE mentioned this pull request Jan 8, 2024
Merged
vsedmik added a commit that referenced this pull request Jan 8, 2024
@Satellite-QE @vsedmik
[6.13.z] Small fix for SyncPlan test (#13665)
e14c8ed 
Small fix for SyncPlan test (#13661)

(cherry picked from commit 07fa9bc)

Co-authored-by: vsedmik <[email protected]>
vsedmik added a commit that referenced this pull request Jan 8, 2024
@Satellite-QE @vsedmik
[6.12.z] Small fix for SyncPlan test (#13663)
dfb0a3d 
Small fix for SyncPlan test (#13661)

(cherry picked from commit 07fa9bc)

Co-authored-by: vsedmik <[email protected]>
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
@vsedmik @shweta83
Small fix for SyncPlan test (SatelliteQE#13661)
aaafade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Griffin-Sullivan Griffin-Sullivan Griffin-Sullivan approved these changes

@sambible sambible sambible approved these changes

Assignees

@vsedmik vsedmik

Labels
6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vsedmik @sambible @Griffin-Sullivan