Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.15.z] - Removing the direct Airgun imports from robottelo #13679

Merged
merged 1 commit into from
Jan 12, 2024
Merged

[6.15.z] - Removing the direct Airgun imports from robottelo #13679

merged 1 commit into from
Jan 12, 2024

Conversation

omkarkhatavkar
Copy link

cherry-pick of #13273

Problem Statement

  • Remove the Airgun Imports from the Robottelo and Use target_sat.ui_session or module_target_sat.ui

Solution

  • UI tests are updated to use the modified "target_sat" or "module_target_sat" for efficient management of multiple browser sessions.
  • The streamlined UI tests function correctly and manage browser sessions effectively.
  • Remove the nailgun entities from the UI code considering the Airgun Imports (some more PR needs to be added remove this as not wanted to do everything in single PR)

@omkarkhatavkar omkarkhatavkar requested review from a team as code owners January 9, 2024 09:54
@omkarkhatavkar omkarkhatavkar added the No-CherryPick PR doesnt need CherryPick to previous branches label Jan 9, 2024
@omkarkhatavkar
Copy link
Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_ldap_authentication.py -k test_positive_delete_external_roles
pod_resources_size: extra_large

@omkarkhatavkar omkarkhatavkar changed the title Removing the direct Airgun imports from robottelo [6.15.z] - Removing the direct Airgun imports from robottelo Jan 9, 2024
@omkarkhatavkar omkarkhatavkar force-pushed the 6.15.z-remove-airgun-imports branch from 972e135 to 3139186 Compare January 11, 2024 11:58
@Satellite-QE @omkarkhatavkar @jyejare
[6.15.z] fixing the incorrect recording video url (SatelliteQE#13722)
865e2a8 
fixing the incorrect recording video url (SatelliteQE#13714)

fixing the recording video url

(cherry picked from commit de84bd3)

Co-authored-by: Omkar Khatavkar <[email protected]>
@jyejare jyejare force-pushed the 6.15.z-remove-airgun-imports branch from 3139186 to 865e2a8 Compare January 12, 2024 09:23
@jyejare
Copy link
Member

jyejare commented Jan 12, 2024

trigger: test-robottelo
pytest: tests/foreman/ui/test_ldap_authentication.py -k test_positive_delete_external_roles
pod_resources_size: extra_large

@jyejare
Copy link
Member

jyejare commented Jan 12, 2024

@omkarkhatavkar Do you think that with 2 tests PRT we can rely on it for the whole test suite ?

@omkarkhatavkar
Copy link
Author

trigger: test-robottelo pytest: tests/foreman/ui/test_ldap_authentication.py -k test_positive_delete_external_roles pod_resources_size: extra_large

These are the tests which use the nested combination if this works normal scenarios will still work anyways.

@omkarkhatavkar
Copy link
Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_ldap_authentication.py -k test_positive_delete_external_roles
pod_resources_size: extra_large

@Gauravtalreja1 Gauravtalreja1 merged commit 6325cf3 into SatelliteQE:6.15.z Jan 12, 2024
6 checks passed
@Gauravtalreja1 Gauravtalreja1 mentioned this pull request Jan 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

Assignees

@omkarkhatavkar omkarkhatavkar

Labels
No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@omkarkhatavkar @jyejare @Gauravtalreja1 @Satellite-QE