Adding coverage for BZ2221621 #13694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmynar
added
CherryPick
JacobCallahan
requested changes
Jan 9, 2024
There was a problem hiding this comment.
You can also use the InstallerCommand class from robottelo.utils.installer instead of constructing the command by string. This isn't a blocker suggestion, though.
https://github.com/SatelliteQE/robottelo/blob/master/robottelo/utils/installer.py#L4
rmynar
force-pushed
the
invalid_certs_bz
branch
from
9a33c10 to
a9f7e0f
Compare
|
trigger: test-robottelo |
|
trigger: test-robottelo |
JacobCallahan
requested changes
Jan 10, 2024
rmynar
force-pushed
the
invalid_certs_bz
branch
from
a9f7e0f to
838d133
Compare
JacobCallahan
approved these changes
Jan 11, 2024
ogajduse
reviewed
Jan 22, 2024
rmynar
force-pushed
the
invalid_certs_bz
branch
from
838d133 to
b69c082
Compare
|
trigger: test-robottelo |
rmynar
force-pushed
the
invalid_certs_bz
branch
from
b69c082 to
21ecf2c
Compare
ogajduse
approved these changes
Jan 24, 2024
This was referenced Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new testcase to cover BZ 2221621 (and it's clone BZ 2238363)
BZ reported in Sat 6.13. Attempting to run installer with invalid certificates on existing installation causes breakage of current setup - hammer ping reports failures. After fix the installer returns error and leaves current setup (hammer ping reports OK statuses)