[6.14.z] Add Ruff rule group B (flake8-bugbear) #13695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change includes the rule addition and mostly manual changes to
existing code in order to bring it in line with the new rules and avoid
as many ignores as is reasonable.
I added a number of {{from err}} statements to the end of exceptions that currently include the error message. The
error message being included in the raised string can be removed later, but keeping for consistency for now.
In cases where I raised from None, the raised exception is clear enough that the additional context of the parent
exception isn't helpful.
cli/test\_ping.py has a zip that should probably be strict.
JacobCallahan
added
Framework Changes
| @@ -235,9 +235,9 @@ def available_capsule_port(self): | |||
| :rtype: int | |||
| """ | |||
| port_pool_range = settings.fake_capsules.port_range | |||
| if type(port_pool_range) is str: | |||
| if isinstance(port_pool_range, list): | |||
There was a problem hiding this comment.
is it correct?
Suggested change
| if isinstance(port_pool_range, list): | |
| if isinstance(port_pool_range, str): |
There was a problem hiding this comment.
@JacobCallahan Could you fix this in master branch manually?
I'll add similar comments to your other cherrypick PRs and we can commit this suggestion in same way
There was a problem hiding this comment.
manual fix required for master and 6.15.z branches*
fix type check from list to str Co-authored-by: Gaurav Talreja <[email protected]>
Gauravtalreja1
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #13491
This change includes the rule addition and mostly manual changes to existing code in order to bring it in line with the new rules and avoid as many ignores as is reasonable.
I added a number of {{from err}} statements to the end of exceptions that currently include the error message. The error message being included in the raised string can be removed later, but keeping for consistency for now.
In cases where I raised from None, the raised exception is clear enough that the additional context of the parent exception isn't helpful.
cli/test_ping.py has a zip that should probably be strict.
fixes #13688