Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for BZ 2139834 #13699

Merged
merged 5 commits into from
Jan 17, 2024
Merged

Conversation

sambible
Copy link
Contributor

Simple CC automation scenario testing the hammer version info command's lifecycle-environment-id and lifecycle-environment flags.

BZ Link: https://bugzilla.redhat.com/show_bug.cgi?id=2139834

@sambible sambible added CherryPick PR needs CherryPick to previous branches 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Jan 10, 2024
@sambible sambible self-assigned this Jan 10, 2024
@sambible sambible requested a review from a team as a code owner January 10, 2024 04:20
Copy link
Contributor

@Griffin-Sullivan Griffin-Sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack pending comment and PRT

)
module_target_sat.cli.ContentView.publish({'id': content_view['id']})
content_view = module_target_sat.cli.ContentView.version_info(
{'id': content_view['id'], 'lifecycle-environment-id': 1}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming the Library env is always ID = 1 but might be safe to also just do a search and make sure we are always getting the right ID instead of hard coding the ID. Also you could create a lifecycle env in the setup and use that ID / name.

@Griffin-Sullivan
Copy link
Contributor

trigger: test-robottelo
pytest: tests/foreman/cli/test_contentview.py -k 'test_version_info_by_lce'

@Griffin-Sullivan Griffin-Sullivan added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Jan 12, 2024
Copy link
Member

@ColeHiggins2 ColeHiggins2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one question pending below.

Also we could leverage the module_cv and module_lce fixtures instead (or their function-scoped brothers), non-blocking.

tests/foreman/cli/test_contentview.py Outdated Show resolved Hide resolved
Copy link
Contributor

@lhellebr lhellebr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sambible
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_contentview.py -k 'test_version_info_by_lce'

@vsedmik vsedmik merged commit ab204d0 into SatelliteQE:master Jan 17, 2024
6 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 17, 2024
* Add test for BZ 2139834

* Update test setup to create a discrete LCE, and publish/promote to there

* Update test setup to create a discrete LCE, and publish/promote to there

* Remove unnecessary publish

(cherry picked from commit ab204d0)
github-actions bot pushed a commit that referenced this pull request Jan 17, 2024
* Add test for BZ 2139834

* Update test setup to create a discrete LCE, and publish/promote to there

* Update test setup to create a discrete LCE, and publish/promote to there

* Remove unnecessary publish

(cherry picked from commit ab204d0)
github-actions bot pushed a commit that referenced this pull request Jan 17, 2024
* Add test for BZ 2139834

* Update test setup to create a discrete LCE, and publish/promote to there

* Update test setup to create a discrete LCE, and publish/promote to there

* Remove unnecessary publish

(cherry picked from commit ab204d0)
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
* Add test for BZ 2139834

* Update test setup to create a discrete LCE, and publish/promote to there

* Update test setup to create a discrete LCE, and publish/promote to there

* Remove unnecessary publish
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants