-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for BZ 2139834 #13699
Add test for BZ 2139834 #13699
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack pending comment and PRT
) | ||
module_target_sat.cli.ContentView.publish({'id': content_view['id']}) | ||
content_view = module_target_sat.cli.ContentView.version_info( | ||
{'id': content_view['id'], 'lifecycle-environment-id': 1} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming the Library env is always ID = 1 but might be safe to also just do a search and make sure we are always getting the right ID instead of hard coding the ID. Also you could create a lifecycle env in the setup and use that ID / name.
trigger: test-robottelo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one question pending below.
Also we could leverage the module_cv
and module_lce
fixtures instead (or their function-scoped brothers), non-blocking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
trigger: test-robottelo |
* Add test for BZ 2139834 * Update test setup to create a discrete LCE, and publish/promote to there * Update test setup to create a discrete LCE, and publish/promote to there * Remove unnecessary publish (cherry picked from commit ab204d0)
* Add test for BZ 2139834 * Update test setup to create a discrete LCE, and publish/promote to there * Update test setup to create a discrete LCE, and publish/promote to there * Remove unnecessary publish (cherry picked from commit ab204d0)
* Add test for BZ 2139834 * Update test setup to create a discrete LCE, and publish/promote to there * Update test setup to create a discrete LCE, and publish/promote to there * Remove unnecessary publish (cherry picked from commit ab204d0)
* Add test for BZ 2139834 * Update test setup to create a discrete LCE, and publish/promote to there * Update test setup to create a discrete LCE, and publish/promote to there * Remove unnecessary publish
Simple CC automation scenario testing the hammer version info command's lifecycle-environment-id and lifecycle-environment flags.
BZ Link: https://bugzilla.redhat.com/show_bug.cgi?id=2139834