Removing changes associated with Bugbear rule B019 #13715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR reverts the change from lru_cache to cachedmethod. The primary goal of the original change was to avoid memory leaks, due to lru_cache holding instances of a class alive longer than they should be. However, for our test framework, the workaround to avoid these memory leaks really aren't worth it. I also added an lru_cache to cli_factory.__getattr__, improving its recurring lookup time substantially. Finally, I corrected a type check that was erroneously converted in the initial pass.
JacobCallahan
added
Bug
omkarkhatavkar
approved these changes
Jan 10, 2024
vsedmik
approved these changes
Jan 10, 2024
|
trigger: test-robottelo |
synkd
approved these changes
Jan 10, 2024
|
PRT results look good, the one error is due to rhel6 checkout, so unrelated. |
This was referenced Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts the change from lru_cache to cachedmethod. The primary goal of the original change was to avoid memory leaks, due to lru_cache holding instances of a class alive longer than they should be.
However, for our test framework, the workaround to avoid these memory leaks really aren't worth it.
I also added an lru_cache to cli_factory.getattr, improving its recurring lookup time substantially.
Finally, I corrected a type check that was erroneously converted in the initial pass.