Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix convert2rhel test #13734

Closed
wants to merge 1 commit into from
Closed

Fix convert2rhel test #13734

wants to merge 1 commit into from

Conversation

shweta83
Copy link
Contributor

Problem Statement

Convert2Rhel tests failing because of outdated packages.

Solution

Updated packages before running convert2rhel job on host

Related Issues

@shweta83 shweta83 requested a review from a team as a code owner January 11, 2024 06:07
@shweta83 shweta83 force-pushed the fix_convert2rhel_test branch from 525f2ae to 21954ff Compare January 11, 2024 06:08
@shweta83 shweta83 added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Jan 11, 2024
@shweta83
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_convert2rhel.py

@shweta83
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_convert2rhel.py -k test_convert2rhel_centos

@synkd
Copy link
Contributor

synkd commented Jan 11, 2024

trigger: test-robottelo
pytest: tests/foreman/api/test_convert2rhel.py -k test_convert2rhel_oracle

@shweta83 shweta83 force-pushed the fix_convert2rhel_test branch 2 times, most recently from 08cedb3 to a63530d Compare January 11, 2024 19:34
@shweta83
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_convert2rhel.py

@shweta83 shweta83 force-pushed the fix_convert2rhel_test branch 3 times, most recently from c76a3c9 to 87b41d2 Compare January 12, 2024 05:10
@shweta83
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_convert2rhel.py -k test_convert2rhel_oracle[oracle8]

@shweta83 shweta83 marked this pull request as draft January 12, 2024 05:15
Gauravtalreja1
Gauravtalreja1 reviewed Jan 12, 2024
View reviewed changes
tests/foreman/api/test_convert2rhel.py Outdated
Comment on lines 210 to 216
oracle_host.execute(
'sed -i -- \'s/CleanupModulesOnExit=yes/CleanupModulesOnExit=no/g\'",'
' "/etc/firewalld/firewalld.conf"'
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have #13236 open, so just checking we're not duplicating effort?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gauravtalreja1 These fixes were not working in the fixture. When fix these after host reboot, then it's working. I don't know the reason behind it but you can update the other PR and we will merge it. Then I can rebase my PR. Whatever works for you. Let me know and let's get this merged.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I'll update 13236 first, where only oracle8 test fails for conversion due to known inhibitor, which we can debug later, but I'd suggest to merge 13236 first, then we can revisit this PR until then we can move this to draft

@shweta83 shweta83 force-pushed the fix_convert2rhel_test branch 3 times, most recently from e81311e to 61eda0a Compare January 15, 2024 10:54
@shweta83
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_convert2rhel.py

1 similar comment
@shweta83
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_convert2rhel.py

@shweta83 shweta83 force-pushed the fix_convert2rhel_test branch from 61eda0a to 67fa788 Compare January 17, 2024 05:35
@shweta83
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_convert2rhel.py

@shweta83 shweta83 marked this pull request as ready for review January 17, 2024 07:50
@Gauravtalreja1 Gauravtalreja1 marked this pull request as draft January 17, 2024 10:38
@shweta83
Copy link
Contributor Author

Closing this PR as the changes are addressed in another PR #14194

@shweta83 shweta83 closed this Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauravtalreja1 Gauravtalreja1 Awaiting requested review from Gauravtalreja1

Assignees

@shweta83 shweta83

Labels
6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shweta83 @synkd @Gauravtalreja1