[6.12.z] Non tabular output denied for CSV conversion #13742
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherrypick of PR: #13737
Problem Statement
The CLI command output containing non-tabular string is not eligible for CSV conversation.
e.g:
STDOUT like
Here zipping in csv conversion function trying to zip the first row of 2 key_value pairs
Added Rpms: 32, Errata: 4
with 1 row of key_value from next lineTotal steps: 84/84
. Since strict is set toTrue
the numbe of contents from first row and second row should match which does match with the tabular format but not the above-like output. Making the the strict zipping to fail.Solution
Returning the output as is if the output is not sniffed using CSV Sniffer for CSV conversion eligibility.
Trying to make it simple though, we could also return all key-value pairs from such output but if the Team demands for it! Since its not returning all key value pairs for such output nobody complaints about it in the past so for now we should be good with the simple solution.
Related Issues