-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release module-streams and container-list assertions #13746
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, ACK pending PRT results.
One non-blocking question: it doesn't look like the PR that fixed https://bugzilla.redhat.com/show_bug.cgi?id=2252450 touched container manifest list counts, was that another recent fix?
Correct, it was brought in elsewhere. However in snap 5 it's fixed, so I uncommented that too. |
trigger: test-robottelo |
Did you rebase before running that last PRT? |
I pulled the latest master before branch and commit, so it should be ok I guess. I will need to dig into it next week locally with the latest airgun and stream snap. Let's see if I can reproduce. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes look ok, Ack
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks reasonable.
ACK Pending PRT
PRT rerun # 5425 passed |
(cherry picked from commit d8fddf3)
Problem Statement
BZ#2252450 blocked us from asserting module streams in UI Capsule Content. Since it has been fixed recently we should be able to check them.
Solution
Uncomment the commented assertions.
Related Issues
For PRT to pass we need to rebase on these (or similar) changes: #13738
Locally it passed.