Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release module-streams and container-list assertions #13746

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented Jan 11, 2024

Problem Statement

BZ#2252450 blocked us from asserting module streams in UI Capsule Content. Since it has been fixed recently we should be able to check them.

Solution

Uncomment the commented assertions.

Related Issues

For PRT to pass we need to rebase on these (or similar) changes: #13738
Locally it passed.

@vsedmik vsedmik added CherryPick PR needs CherryPick to previous branches 6.15.z Introduced in or relating directly to Satellite 6.15 labels Jan 11, 2024
@vsedmik vsedmik self-assigned this Jan 11, 2024
@vsedmik vsedmik requested a review from a team as a code owner January 11, 2024 14:10
Copy link
Contributor

@synkd synkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, ACK pending PRT results.

One non-blocking question: it doesn't look like the PR that fixed https://bugzilla.redhat.com/show_bug.cgi?id=2252450 touched container manifest list counts, was that another recent fix?

@vsedmik
Copy link
Contributor Author

vsedmik commented Jan 11, 2024

Looks good, ACK pending PRT results.

One non-blocking question: it doesn't look like the PR that fixed https://bugzilla.redhat.com/show_bug.cgi?id=2252450 touched container manifest list counts, was that another recent fix?

Correct, it was brought in elsewhere. However in snap 5 it's fixed, so I uncommented that too.

@vsedmik
Copy link
Contributor Author

vsedmik commented Jan 11, 2024

trigger: test-robottelo
pytest: tests/foreman/ui/test_capsulecontent.py -k mixed_cv

@Griffin-Sullivan
Copy link
Contributor

Did you rebase before running that last PRT?

@vsedmik
Copy link
Contributor Author

vsedmik commented Jan 12, 2024

I pulled the latest master before branch and commit, so it should be ok I guess. I will need to dig into it next week locally with the latest airgun and stream snap. Let's see if I can reproduce.

Copy link
Contributor

@vijaysawant vijaysawant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look ok, Ack

Copy link
Member

@rplevka rplevka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks reasonable.
ACK Pending PRT

@vsedmik
Copy link
Contributor Author

vsedmik commented Jan 18, 2024

PRT rerun # 5425 passed

@vsedmik vsedmik added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Jan 18, 2024
@vsedmik vsedmik merged commit d8fddf3 into SatelliteQE:master Jan 18, 2024
9 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 18, 2024
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants