Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.15.z] Refactor and simplify ping test #13755

Merged

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #13489

Cache status was added to hammer ping output and there can be more cache servers configured so the output syntax has changed. I changed and simplified the test so it can parse current output and it also meets test description.

sample output:

database:         
    Status:          ok
    Server Response: Duration: 0ms
cache:            
    servers: 
     1) Status:          ok
        Server Response: Duration: 0ms
candlepin:        
    Status:          ok
    Server Response: Duration: 23ms
...

PS: I'm not aware of negative scenario for this testcase (i.e. scenario when some of Satellite services report status "FAIL"). We may add it in future.

@Satellite-QE Satellite-QE requested a review from a team as a code owner January 11, 2024 15:10
@Satellite-QE Satellite-QE added 6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Jan 11, 2024
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_ping.py

Copy link
Member

@ogajduse ogajduse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRT passed

@ogajduse ogajduse merged commit a89cb8c into 6.15.z Jan 11, 2024
12 checks passed
@ogajduse ogajduse deleted the cherry-pick-6.15.z-d984b2b8438e0b4bb8ccadba2cce77f8d85c6b8c branch January 11, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants