Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.14.z] Cleanup video recording #13770

Merged
merged 1 commit into from
Jan 12, 2024
Merged

[6.14.z] Cleanup video recording #13770

merged 1 commit into from
Jan 12, 2024
+15 −12

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #13713

Problem Statement

  • missing ui setting record_video breaks tests
  • robottelo tests fail in teardwon despite record_video is set to false

Solution

  • Only call related functionality when record_video is set to true
  • Add settings options to config template

Related Issues

@dosas @web-flow
Cleanup video recording (#13713)
3738e59 
* Only call related functionallity when
  record_video is set to true
* Add settings options to config template

Co-authored-by: dosas <[email protected]>
(cherry picked from commit ad6b99f)
@Satellite-QE Satellite-QE added 6.14.z Introduced in or relating directly to Satellite 6.14 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Jan 12, 2024
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_ldap_authentication.py -k test_positive_delete_external_roles
pod_resources_size: extra_large
env:
ROBOTTELO_ui__record_video: true

@Gauravtalreja1 Gauravtalreja1 merged commit f78b348 into 6.14.z Jan 12, 2024
18 checks passed
@Gauravtalreja1 Gauravtalreja1 deleted the cherry-pick-6.14.z-ad6b99ffb7d87bcd41ff86d256df900568644d86 branch January 12, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

Assignees

@dosas dosas

Labels
6.14.z Introduced in or relating directly to Satellite 6.14 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Satellite-QE @Gauravtalreja1 @dosas