Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.15.z] cli_factory job_invocation fix #13803

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #13797

Problem Statement

With recent changes in cli factory (I'd say both #13491 and #13737 have a hand in this) a bunch of rex tests started to fail with box.exceptions.BoxValueError: Cannot extrapolate Box from string

The job invocation hammer command returns something like 'Message,Id\nJob invocation 12 created,12\n1 task(s), 1 success, 0 fail\n' which does not pass the is_csv check here https://github.com/jyejare/robottelo/blob/fcd09d84d933cf9e170291fac8e3c6af81f39870/robottelo/cli/hammer.py#L37 , but even if it did it would fail with the zip error as there are three lines

Solution

Checking if the output is coming from the invocation command and adjusting accordingly.

@Satellite-QE Satellite-QE requested a review from a team as a code owner January 16, 2024 13:22
@Satellite-QE Satellite-QE added 6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Jan 16, 2024
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_remoteexecution.py -k test_positive_run_packages_and_services_job[rhel8]

@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Jan 16, 2024
@Satellite-QE Satellite-QE merged commit 4763b87 into 6.15.z Jan 16, 2024
14 checks passed
@Satellite-QE Satellite-QE deleted the cherry-pick-6.15.z-f351608d903d08636f92e31b6bd8264958c90fa5 branch January 16, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants