remove the all nailgun imports from UI folder #13809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omkarkhatavkar
added
CherryPick
omkarkhatavkar
force-pushed
the
ui_remove_nailgun_import
branch
from
0bb3d9a to
ca3c081
Compare
|
Needs review here @SatelliteQE/tier-1-reviewers and @SatelliteQE/tier-2-reviewers. |
omkarkhatavkar
force-pushed
the
ui_remove_nailgun_import
branch
from
ca3c081 to
990899a
Compare
jyejare
approved these changes
Jan 29, 2024
|
@omkarkhatavkar ACKed based on the comments addressed but the checks are failing, please fix ! |
omkarkhatavkar
force-pushed
the
ui_remove_nailgun_import
branch
2 times, most recently
from
1fd56df to
e6d68b1
Compare
omkarkhatavkar
changed the title
|
@Gauravtalreja1 @jyejare Can you please review this PR again? waiting for more than 3 weeks. |
omkarkhatavkar
force-pushed
the
ui_remove_nailgun_import
branch
from
e6d68b1 to
66f0d21
Compare
jyejare
approved these changes
Feb 6, 2024
shweta83
pushed a commit
to shweta83/robottelo
that referenced
this pull request
Apr 10, 2024
remove the all nailgum imports from UI folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
We are using the direct imports from the nailgun rather than directly using from target_sat
Solution
Direct Imports Removed: We've cleaned up our codebase by eliminating direct imports from the Nailgun package.
Using target_sat, module_target_sat, class_target_sat: Modified the API calls and using the target_sat.api. pattern for all API calls.