-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ensure mqtt capsule is not bypassed #13817
Conversation
trigger: test-robottelo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good,, suggestions are non-blocking typo corrections.
applied suggestions, note: please do squash-merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't both modified tests use the setting_update
fixture to ensure that the setting returns to its original value? That way, the environment should stay unchanged for other tests that will run after these two.
https://github.com/SatelliteQE/robottelo/blob/2b1bf9b56d4ce61dd2d042ff16148958aa2c83ee/pytest_fixtures/component/settings.py#L6-L22
92bd8aa
to
1c1e692
Compare
trigger: test-robottelo |
ACK |
1c1e692
to
d3d112a
Compare
trigger: test-robottelo |
trigger: test-robottelo |
@@ -73,13 +73,15 @@ def test_positive_run_capsule_upgrade_playbook(module_capsule_configured, target | |||
@pytest.mark.tier3 | |||
@pytest.mark.no_containers | |||
@pytest.mark.rhel_ver_list('8') | |||
@pytest.mark.parametrize('setting_update', ['remote_execution_global_proxy=False'], indirect=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with unchanged parameter name, pytest has issues with =False
in the test name (see your recent PRT job).
I'd suggest calling the parameter no-rex-global-proxy
or so.
you can do it by passing another parameter, called ids
relevant docs
d3d112a
to
d24860e
Compare
d24860e
to
9c83132
Compare
trigger: test-robottelo |
trigger: test-robottelo |
(cherry picked from commit 7f317a6)
(cherry picked from commit 7f317a6)
(cherry picked from commit 7f317a6)
Problem Statement
With global proxy setting on, it is possible that if the mqtt capsule is not reached, the default one is used instead. In such case we wouldn't find out there is a problem.
Solution
This PR forces the registered through capsule for the tests using external capsule