Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reclaim_space endpoint path #13842

Closed
wants to merge 1 commit into from
Closed

Fix reclaim_space endpoint path #13842

wants to merge 1 commit into from

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented Jan 22, 2024

Problem Statement

In 6.15.0 the reclaim_space endpoint was moved behind the content section in BZ#2218179 (also see the 6.15 results for tests.foreman.endtoend.test_api_endtoend.TestAvailableURLs.test_positive_get_links, it fails)

Solution

Move it in this test too.

@vsedmik vsedmik added CherryPick PR needs CherryPick to previous branches 6.15.z Introduced in or relating directly to Satellite 6.15 labels Jan 22, 2024
@vsedmik vsedmik self-assigned this Jan 22, 2024
@vsedmik vsedmik requested a review from a team as a code owner January 22, 2024 08:36
@vsedmik vsedmik requested a review from pondrejk January 22, 2024 08:46
@vsedmik
Copy link
Contributor Author

vsedmik commented Jan 22, 2024

trigger: test-robottelo
pytest: tests/foreman/endtoend/test_api_endtoend.py -k test_positive_get_links

@vsedmik
Copy link
Contributor Author

vsedmik commented Jan 22, 2024

Ad PRT - the reclaim_space failure is now missing.

@Gauravtalreja1
Copy link
Collaborator 

trigger: test-robottelo
pytest: tests/foreman/endtoend/test_api_endtoend.py -k get_links
env:
    ROBOTTELO_server__deploy_arguments__deploy_sat_version: '6.15'

Gauravtalreja1
Gauravtalreja1 reviewed Jan 25, 2024
View reviewed changes
tests/foreman/endtoend/test_api_endtoend.py
@@ -153,7 +153,7 @@
'/katello/api/capsules/:id/content/sync',
'/katello/api/capsules/:id/content/sync',
'/katello/api/capsules/:id/content/sync',
'/katello/api/capsules/:id/reclaim_space',
'/katello/api/capsules/:id/content/reclaim_space',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vsedmik this update was already included in @pondrejk 's PR which updates other endpoints too, so are we good closing this PR now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, how dare you!! :D

@vsedmik
Copy link
Contributor Author

vsedmik commented Jan 25, 2024

Closing in favour of #13857

@vsedmik vsedmik closed this Jan 25, 2024
@vsedmik vsedmik deleted the fix-reclaim-space branch January 25, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

@pondrejk pondrejk Awaiting requested review from pondrejk

Assignees

@vsedmik vsedmik

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 CherryPick PR needs CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vsedmik @Gauravtalreja1