Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli oscap fix name already taken #13856

Merged
merged 1 commit into from
Jan 23, 2024
Merged

cli oscap fix name already taken #13856

merged 1 commit into from
Jan 23, 2024

Conversation

pondrejk
Copy link
Contributor

Problem Statement

some tests were relying on the default factory title for the newly created scap contents, which caused a bunch of 'name already taken' failures for parametrized tests

Solution

just create the title within the test body

@pondrejk pondrejk added TestFailure Issues and PRs related to a test failing in automation CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Jan 22, 2024
@pondrejk pondrejk self-assigned this Jan 22, 2024
@pondrejk pondrejk requested a review from a team as a code owner January 22, 2024 11:28
@pondrejk
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_oscap.py -k test_positive_delete_scap_content_with_id

@Gauravtalreja1 Gauravtalreja1 added the Easy Fix :) Easiest Fix to review and quick merge request. label Jan 23, 2024
@Gauravtalreja1 Gauravtalreja1 merged commit 5e2585a into SatelliteQE:master Jan 23, 2024
12 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 23, 2024
@pondrejk @web-flow
cli oscap fix name already taken (#13856)
22bf6ce 
(cherry picked from commit 5e2585a)
@Satellite-QE Satellite-QE mentioned this pull request Jan 23, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Jan 23, 2024
@pondrejk @web-flow
cli oscap fix name already taken (#13856)
9c455ee 
(cherry picked from commit 5e2585a)
@Satellite-QE Satellite-QE mentioned this pull request Jan 23, 2024
Merged
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
@pondrejk @shweta83
cli oscap fix name already taken (SatelliteQE#13856)
4b68173
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

Assignees

@pondrejk pondrejk

Labels
6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches Easy Fix :) Easiest Fix to review and quick merge request. TestFailure Issues and PRs related to a test failing in automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pondrejk @Gauravtalreja1