additional check before create issue for failed cherrypick #13858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omkarkhatavkar
changed the title
omkarkhatavkar
force-pushed
the
check_before_create_issue
branch
from
b17523e to
33caced
Compare
omkarkhatavkar
force-pushed
the
check_before_create_issue
branch
from
33caced to
5d73ab3
Compare
omkarkhatavkar
added
CherryPick
JacobCallahan
approved these changes
Jan 23, 2024
ColeHiggins2
approved these changes
Jan 23, 2024
ogajduse
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
There have been occurrences where the PR issue was created for passed cherrypicks as well. There has to be a check before creating an issue. The discussion and further details point to these comments #13831 (comment)
Solution
An additional check is added to this PR, it will try to check if the PR exists with that branch name, if yes then it will not raise any concerns or create issues.
Related Issues
#13831 (comment)