Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.13.z] fixes in api role helper functions #13866

Merged
merged 1 commit into from
Jan 23, 2024
Merged

[6.13.z] fixes in api role helper functions #13866

merged 1 commit into from
Jan 23, 2024

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #13849

Problem Statement

#12989 updated the create_domain and create_simple_user helpers to use target_sat but didn't update all the callers accordingly

Solution

this pr

@Satellite-QE Satellite-QE added 6.13.z Introduced in or relating directly to Satellite 6.13 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Jan 23, 2024
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/api/test_role.py -k test_negative_access_entities_from_org_admin

@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Jan 23, 2024
@Gauravtalreja1
Copy link
Collaborator

PRT failure is due to missing cherrypick of #13465

@Gauravtalreja1 Gauravtalreja1 mentioned this pull request Jan 23, 2024
Merged
@pondrejk @Gauravtalreja1
fixes in api role helper functions (#13849)
b421635 
paramter order in api role helper functions

(cherry picked from commit b588165)
@Gauravtalreja1 Gauravtalreja1 force-pushed the cherry-pick-6.13.z-b588165f567a830ef7175b08128ce34295e4dfd2 branch from 4056a13 to b421635 Compare January 23, 2024 14:22
@Gauravtalreja1
Copy link
Collaborator

trigger: test-robottelo
pytest: tests/foreman/api/test_role.py

Gauravtalreja1
Gauravtalreja1 approved these changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@Gauravtalreja1 Gauravtalreja1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, 4 PRT failures looks common with master/stream

@Gauravtalreja1 Gauravtalreja1 merged commit cf01b5c into 6.13.z Jan 23, 2024
5 of 6 checks passed
@Gauravtalreja1 Gauravtalreja1 deleted the cherry-pick-6.13.z-b588165f567a830ef7175b08128ce34295e4dfd2 branch January 23, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

Assignees

@pondrejk pondrejk

Labels
6.13.z Introduced in or relating directly to Satellite 6.13 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Satellite-QE @Gauravtalreja1 @pondrejk