Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.15.z] fix in test_permission #13874

Merged

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #13871

Problem Statement

#12989 swapped entities for target_sat.api but:

(Pdb) entities.ActivationKey
<class 'nailgun.entities.ActivationKey'>
(Pdb) target_sat.api.ActivationKey
<class 'robottelo.hosts.Satellite.api.<locals>.inject_config.<locals>.DecClass'>

which breaks the if condition in this test

Solution

Swapping back to entities, as it is still heavily used in that module. Deferring further changes to component evaluation

(cherry picked from commit 39ba6ff)
@Satellite-QE Satellite-QE requested a review from a team as a code owner January 23, 2024 12:07
@Satellite-QE Satellite-QE added 6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Jan 23, 2024
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/api/test_permission.py -k test_positive_check_update[2]

@pondrejk
Copy link
Contributor

prt build 5473 passed

@pondrejk pondrejk merged commit a9d5b84 into 6.15.z Jan 23, 2024
12 checks passed
@pondrejk pondrejk deleted the cherry-pick-6.15.z-39ba6ffaaf4c2e82b2c0e82d989aad0873669dca branch January 23, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants