Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added test_positive_host_registration_with_non_admin_user #13915

Merged
merged 3 commits into from
Feb 8, 2024

Conversation

amolpati30
Copy link
Contributor

Problem Statement

Global Registration using an new user with "Register Hosts" role ignores all the setup options.

Solution

Provided solution will fix the global registration problem with non-admin user

Related Issues

No

@amolpati30 amolpati30 added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Jan 29, 2024
@amolpati30 amolpati30 requested a review from a team as a code owner January 29, 2024 09:21
@amolpati30
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_registration.py::test_positive_host_registration_with_non_admin_user

@amolpati30
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_registration.py::test_positive_host_registration_with_non_admin_user

tests/foreman/api/test_registration.py Outdated Show resolved Hide resolved
tests/foreman/api/test_registration.py Outdated Show resolved Hide resolved
Copy link
Member

@ogajduse ogajduse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one non-blocking comment.
ACK, pending @Gauravtalreja1's questions.

Edit: Nice first addition, Amol. 👍

tests/foreman/api/test_registration.py Outdated Show resolved Hide resolved
@amolpati30 amolpati30 force-pushed the test_01 branch 3 times, most recently from bb0dacb to 72abf29 Compare January 30, 2024 17:38
@amolpati30 amolpati30 force-pushed the test_01 branch 2 times, most recently from 0ca395e to b8f8c5d Compare February 5, 2024 09:02
@amolpati30
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_registration.py -k test_positive_host_registration_with_non_admin_user_with_setup_false

@Gauravtalreja1
Copy link
Collaborator

trigger: test-robottelo
pytest: tests/foreman/api/test_registration.py -k test_positive_host_registration_with_non_admin_user_with_setup_false

@Gauravtalreja1 Gauravtalreja1 added QETestCoverage Issues and PRs relating to a Satellite bug and removed 6.13.z Introduced in or relating directly to Satellite 6.13 labels Feb 8, 2024
@Gauravtalreja1
Copy link
Collaborator

Gauravtalreja1 commented Feb 8, 2024

Great job @amolpati30 with your first PR ❤️
BZ is fixed in 6.14.0, so we don't need cherrypick for 6.13.z here atm

@Gauravtalreja1 Gauravtalreja1 merged commit 954d971 into SatelliteQE:master Feb 8, 2024
9 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 8, 2024
* added test_positive_host_registration_with_non_admin_user

* updated assert_info

* Update tests/foreman/api/test_registration.py

Co-authored-by: Gaurav Talreja <[email protected]>

---------

Co-authored-by: Gaurav Talreja <[email protected]>
(cherry picked from commit 954d971)
github-actions bot pushed a commit that referenced this pull request Feb 8, 2024
* added test_positive_host_registration_with_non_admin_user

* updated assert_info

* Update tests/foreman/api/test_registration.py

Co-authored-by: Gaurav Talreja <[email protected]>

---------

Co-authored-by: Gaurav Talreja <[email protected]>
(cherry picked from commit 954d971)
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
…E#13915)

* added test_positive_host_registration_with_non_admin_user

* updated assert_info

* Update tests/foreman/api/test_registration.py

Co-authored-by: Gaurav Talreja <[email protected]>

---------

Co-authored-by: Gaurav Talreja <[email protected]>
@amolpati30 amolpati30 deleted the test_01 branch August 26, 2024 04:03
@amolpati30 amolpati30 restored the test_01 branch August 26, 2024 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches QETestCoverage Issues and PRs relating to a Satellite bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants