Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes for CLI post-eval failures #13928

Merged
merged 1 commit into from
Feb 6, 2024
Merged

fixes for CLI post-eval failures #13928

merged 1 commit into from
Feb 6, 2024

Conversation

damoore044
Copy link
Contributor

@damoore044 damoore044 commented Jan 29, 2024 •
edited
Loading

Some Errata action items for failing setup and some sorting tests.

  • Changed nearly all module_entitlement_manifest_org to module_sca_manifest_org, the fixture often failed setup for no manifest content. This also prepares cli testing for SCA-only orgs coming in 6.16.0.
  • Changed some remaining rh repo references from RHEL7 and RHST7, to RHEL8 and RHSClient8
  • Updated some expected output from JobInvocation being created/started, checking completed status.
  • Properly reading cli output, for errata 'Issue' and 'Update' dates

@damoore044 damoore044 added CherryPick PR needs CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master 6.15.z Introduced in or relating directly to Satellite 6.15 labels Jan 29, 2024
@damoore044 damoore044 self-assigned this Jan 29, 2024
@damoore044 damoore044 marked this pull request as ready for review January 30, 2024 16:04
@damoore044 damoore044 requested a review from a team as a code owner January 30, 2024 16:04
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_errata.py

@damoore044 damoore044 requested a review from a team January 31, 2024 13:10
@damoore044 damoore044 added the 6.14.z Introduced in or relating directly to Satellite 6.14 label Jan 31, 2024
@damoore044 damoore044 force-pushed the master branch 2 times, most recently from 6827878 to dfb2f53 Compare February 1, 2024 13:23
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_errata.py

@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_errata.py

ogajduse
ogajduse approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@ogajduse ogajduse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, pending Gaurav's comments.
It would be great to have someone from the Phoenix team review the changes from the test logic PoV.

sambible
sambible approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@sambible sambible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. LGTM

@Gauravtalreja1 Gauravtalreja1 added AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing and removed Stream Introduced in or relating directly to Satellite Stream/Master labels Feb 6, 2024
@damoore044
CLI post-eval failures
2875c4a 
parameterized errata_host fixture by rhel_version
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_errata.py

@Gauravtalreja1 Gauravtalreja1 merged commit 834acb4 into SatelliteQE:master Feb 6, 2024
6 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 6, 2024
@damoore044 @web-flow
fixes for CLI post-eval failures (#13928)
4e1031b 
CLI post-eval failures

parameterized errata_host fixture by rhel_version

(cherry picked from commit 834acb4)
@Satellite-QE Satellite-QE mentioned this pull request Feb 6, 2024
Merged
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
@damoore044 @shweta83
fixes for CLI post-eval failures (SatelliteQE#13928)
b67beff 
CLI post-eval failures

parameterized errata_host fixture by rhel_version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@synkd synkd synkd approved these changes

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

@ogajduse ogajduse ogajduse approved these changes

@sambible sambible sambible approved these changes

@omkarkhatavkar omkarkhatavkar omkarkhatavkar approved these changes

Assignees

@damoore044 damoore044

Labels
6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@damoore044 @omkarkhatavkar @sambible @ogajduse @Gauravtalreja1 @synkd