-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix parametrization in test_positive_reboot_all_pxe_hosts #13949
Fix parametrization in test_positive_reboot_all_pxe_hosts #13949
Conversation
trigger: test-robottelo |
595e289
to
0c26452
Compare
trigger: test-robottelo |
ACK on the intent of the changes, but can you determine why the test is failing in PRT? If unrelated to your change, then the failure isn't a blocker. |
0c26452
to
4fe59e1
Compare
trigger: test-robottelo |
PRT Result
|
Signed-off-by: Gaurav Talreja <[email protected]>
4fe59e1
to
8044a37
Compare
Yes, the failure isn't related to the changes of this PR, but it is related to a BZ 2264195, I've opened a quick fix theforeman/foreman_discovery#623 in upstream already and handled the changes here. |
Signed-off-by: Gaurav Talreja <[email protected]> (cherry picked from commit 55109fb)
Signed-off-by: Gaurav Talreja <[email protected]> (cherry picked from commit 55109fb)
Signed-off-by: Gaurav Talreja <[email protected]> (cherry picked from commit 55109fb)
…14083) Fix parametrization in test_positive_reboot_all_pxe_hosts (#13949) Signed-off-by: Gaurav Talreja <[email protected]> (cherry picked from commit 55109fb) Co-authored-by: Gaurav Talreja <[email protected]>
…14084) Fix parametrization in test_positive_reboot_all_pxe_hosts (#13949) Signed-off-by: Gaurav Talreja <[email protected]> (cherry picked from commit 55109fb) Co-authored-by: Gaurav Talreja <[email protected]>
…14085) Fix parametrization in test_positive_reboot_all_pxe_hosts (#13949) Signed-off-by: Gaurav Talreja <[email protected]> (cherry picked from commit 55109fb) Co-authored-by: Gaurav Talreja <[email protected]>
…E#13949) Signed-off-by: Gaurav Talreja <[email protected]>
Problem Statement
Missing
indirect=True
in parametrization for provision_multiple_hosts fixture which causes,Solution
using getattr to set count as default for this fixture, and removing
@pytest.mark.parametrize
for this fixture, along with mark for pxe_loader fixture which also has bios set as default.