Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.15.z] small fix related to repo sync bulk canceled scenario #13952

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #13951

Problem Statement

2 tests from foreman/api/test_repository.py were failing due to TyepError
Test cases name: test_positive_cancel_docker_repo_sync and test_positive_bulk_cancel_sync

TypeError: ForemanTask.poll() got an unexpected keyword argument 'canceled'

Solution

Poll() from ForemaTask of nailgun entities return status of task and the argument must_succeed would raised error if tasks finishes with other than success result, as we are cancelling sync so poll would raise error so passing False will resolve this error.

Related Issues

No

@Satellite-QE Satellite-QE requested a review from a team as a code owner January 31, 2024 13:01
@Satellite-QE Satellite-QE added 6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Jan 31, 2024
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/api/test_repository.py::TestRepositorySync::test_positive_bulk_cancel_sync tests/foreman/api/test_repository.py::TestDockerRepository::test_positive_cancel_docker_repo_sync

@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Jan 31, 2024
@Satellite-QE Satellite-QE merged commit 683836a into 6.15.z Jan 31, 2024
14 checks passed
@Satellite-QE Satellite-QE deleted the cherry-pick-6.15.z-2c726d838557dc18e3dd4b4c58100f37c70917b6 branch January 31, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants