Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small correction in hammer repository create command #13956

Conversation

vijaysawant
Copy link
Contributor

Problem Statement

  1. Test TestAnsibleCollectionRepository::test_positive_sync_ansible_collection_from_satellite[ansible_galaxy] was failing due to wrong option passed to hammer command.

Applicable only for 6.14.z, 6.15.z and stream

Error: Unrecognised option '--ansible-collection-reqirements'.

  1. Also in 6.14.2 test run build no 33 of Phoenix-content > foreman/cli/test/ detected one regression for test module / test case test_repository.py::TestAnsibleCollectionRepository::test_positive_sync_ansible_collection[ansible_hub] and error was related to repository synchronize. When tested locally test passed, wanted to make sure this test passes or not in CI so I would run separate PRT comment for that.

trigger: test-robottelo
pytest: tests/foreman/cli/test_repository.py::TestAnsibleCollectionRepository::test_positive_sync_ansible_collection

Solution

  1. This PR will solve the above error.
  2. Seperate PRT comment would be run for regression test, to make sure regression in test module
    Local test result:
Launching pytest with arguments -k test_positive_sync_ansible_collection -vvs /__path__/robottelo/tests/foreman/cli/test_repository.py --no-header --no-summary -q in /__path__/robottelo

============================= test session starts ==============================
collecting ... 2024-01-31 19:00:13 - robottelo.collection - INFO - Processing test items to add testimony token markers
collected 169 items / 166 deselected / 3 selected

tests/foreman/cli/test_repository.py::TestAnsibleCollectionRepository::test_positive_sync_ansible_collection[ansible_galaxy] 
tests/foreman/cli/test_repository.py::TestAnsibleCollectionRepository::test_positive_sync_ansible_collection[ansible_hub] 
tests/foreman/cli/test_repository.py::TestAnsibleCollectionRepository::test_positive_sync_ansible_collection_from_satellite[ansible_galaxy] 

=========== 1 failed, 2 passed, 166 deselected in 389.82s (0:06:29) ============
PASSEDPASSEDFAILED

Related Issues

No

@vijaysawant vijaysawant added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing Stream Introduced in or relating directly to Satellite Stream/Master 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Jan 31, 2024
@vijaysawant vijaysawant requested a review from a team as a code owner January 31, 2024 14:46
@vijaysawant
Copy link
Contributor Author

vijaysawant commented Jan 31, 2024

Note- PRT comment to check regression, which is not part of this fix. Build 5566

@vijaysawant vijaysawant marked this pull request as draft January 31, 2024 14:59
@vijaysawant
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_repository.py::TestAnsibleCollectionRepository::test_positive_sync_ansible_collection

@vijaysawant
Copy link
Contributor Author

vijaysawant commented Jan 31, 2024

Note: Now running PRT comment for the fix provided. Build 5567

trigger: test-robottelo
pytest: tests/foreman/cli/test_repository.py::TestAnsibleCollectionRepository::test_positive_sync_ansible_collection_from_satellite

@vijaysawant
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_repository.py::TestAnsibleCollectionRepository::test_positive_sync_ansible_collection_from_satellite

@vijaysawant vijaysawant added the 6.13.z Introduced in or relating directly to Satellite 6.13 label Jan 31, 2024
@vijaysawant vijaysawant marked this pull request as ready for review January 31, 2024 15:34
@vijaysawant
Copy link
Contributor Author

Build 5567 has Passed!

@vsedmik vsedmik merged commit 67b7e33 into SatelliteQE:master Jan 31, 2024
13 checks passed
@Gauravtalreja1 Gauravtalreja1 added the Easy Fix :) Easiest Fix to review and quick merge request. label Jan 31, 2024
github-actions bot pushed a commit that referenced this pull request Jan 31, 2024
github-actions bot pushed a commit that referenced this pull request Jan 31, 2024
github-actions bot pushed a commit that referenced this pull request Jan 31, 2024
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches Easy Fix :) Easiest Fix to review and quick merge request. Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants