Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errata coverage for CV Incremental Update #13994

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Errata coverage for CV Incremental Update #13994

merged 1 commit into from
Feb 13, 2024

Conversation

damoore044
Copy link
Contributor

@damoore044 damoore044 commented Feb 5, 2024 •
edited
Loading

Purpose

  • Add coverage for incremental update, that it is available when expected, and
  • that the expected host's content-view and environment(s) are are updated as expected, and
  • the available errata/packages to host are updated by the incremental version as expected.
  • we can install updated packages and see the expected (filtered-security only) applicable errata/count drops, and
    the applicable packages count drops.
  • modification to helper method cv_publish_promote, which did not always filter environment ids for promotion as expected.

Coverage reason

We already have some testing for if any incremental update is needed on a single view/environment, test_positive_incremental_update_required:

  • But the existing test doesn't check the successful update and new CV version itself (contained errata/content). Or how the registered host's applicability is affected by the new version.

PRT Case

trigger: test-robottelo
pytest: tests/foreman/api/test_errata.py::test_positive_incremental_update_apply_to_envs_cvs

@damoore044 damoore044 requested a review from a team as a code owner February 5, 2024 18:34
@damoore044 damoore044 force-pushed the errata-incremental-update branch from 5cc7aca to b4372ed Compare February 5, 2024 18:34
@damoore044 damoore044 requested a review from a team February 5, 2024 18:34
@damoore044 damoore044 added CherryPick PR needs CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master 6.15.z Introduced in or relating directly to Satellite 6.15 labels Feb 5, 2024
@damoore044 damoore044 force-pushed the errata-incremental-update branch 4 times, most recently from 90f6cb4 to 10982b5 Compare February 5, 2024 19:54
sambible
sambible requested changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@sambible sambible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment change, and a question, but overall looks like a through test. Good work.

@damoore044 damoore044 force-pushed the errata-incremental-update branch 2 times, most recently from 9f8ea6a to 4c9e109 Compare February 5, 2024 23:13
@damoore044 damoore044 requested a review from sambible February 5, 2024 23:51
@damoore044 damoore044 force-pushed the errata-incremental-update branch 12 times, most recently from a10212f to 5980bdf Compare February 6, 2024 15:21
@damoore044 damoore044 removed the request for review from a team February 6, 2024 15:43
@damoore044 damoore044 force-pushed the errata-incremental-update branch from 27db8fe to 46fca98 Compare February 6, 2024 15:43
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_errata.py::test_positive_incremental_update_apply_to_envs_cvs

vijaysawant
vijaysawant requested changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@vijaysawant vijaysawant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggested few changes

@damoore044 damoore044 force-pushed the errata-incremental-update branch from 46fca98 to 04477d6 Compare February 7, 2024 17:04
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_errata.py::test_positive_incremental_update_apply_to_envs_cvs

2 similar comments
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_errata.py::test_positive_incremental_update_apply_to_envs_cvs

@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_errata.py::test_positive_incremental_update_apply_to_envs_cvs

@vijaysawant
Copy link
Contributor

Build 5652 failed due to broken setup
failed on setup with "ModuleNotFoundError: No module named 'docker'"

@damoore044 damoore044 force-pushed the errata-incremental-update branch from 04477d6 to 2980722 Compare February 8, 2024 16:46
@damoore044 damoore044 requested a review from a team as a code owner February 8, 2024 16:46
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_errata.py::test_positive_incremental_update_apply_to_envs_cvs

@damoore044 damoore044 force-pushed the errata-incremental-update branch from 2980722 to fb69396 Compare February 8, 2024 17:22
@damoore044 damoore044 force-pushed the errata-incremental-update branch from fb69396 to 5954fce Compare February 8, 2024 18:24
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_errata.py::test_positive_incremental_update_apply_to_envs_cvs

@damoore044 damoore044 force-pushed the errata-incremental-update branch from 5954fce to 00d12f2 Compare February 8, 2024 18:52
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_errata.py::test_positive_incremental_update_apply_to_envs_cvs

ColeHiggins2
ColeHiggins2 approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@ColeHiggins2 ColeHiggins2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack pending @sambible approval

sambible
sambible approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@sambible sambible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, lgtm

@sambible sambible force-pushed the errata-incremental-update branch from 00d12f2 to 19e6066 Compare February 13, 2024 16:50
@sambible sambible enabled auto-merge (squash) February 13, 2024 16:50
@sambible sambible merged commit f9e5fc6 into SatelliteQE:master Feb 13, 2024
6 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 13, 2024
@damoore044 @web-flow
Errata coverage for CV Incremental Update (#13994)
2bc31de 
Incremental update errata coverage

(cherry picked from commit f9e5fc6)
@Satellite-QE Satellite-QE mentioned this pull request Feb 13, 2024
Merged
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
@damoore044 @shweta83
Errata coverage for CV Incremental Update (SatelliteQE#13994)
0c96ff2 
Incremental update errata coverage
@damoore044 damoore044 deleted the errata-incremental-update branch February 20, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobCallahan JacobCallahan JacobCallahan left review comments

@sambible sambible sambible approved these changes

@ColeHiggins2 ColeHiggins2 ColeHiggins2 approved these changes

@vijaysawant vijaysawant vijaysawant approved these changes

@Gauravtalreja1 Gauravtalreja1 Awaiting requested review from Gauravtalreja1

Assignees

@damoore044 damoore044

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 CherryPick PR needs CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@damoore044 @vijaysawant @JacobCallahan @sambible @Gauravtalreja1 @ColeHiggins2