Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli e2e fix #13999

Merged
merged 1 commit into from
Apr 8, 2024
Merged

cli e2e fix #13999

merged 1 commit into from
Apr 8, 2024

Conversation

pondrejk
Copy link
Contributor

@pondrejk pondrejk commented Feb 6, 2024

Problem Statement

e2e failing with key error

Solution

updating the assert

@pondrejk pondrejk added CLI Issues and PRs involving the CLI TestFailure Issues and PRs related to a test failing in automation CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Feb 6, 2024
@pondrejk pondrejk self-assigned this Feb 6, 2024
@pondrejk pondrejk requested a review from a team as a code owner February 6, 2024 11:59
@pondrejk
Copy link
Contributor Author

pondrejk commented Feb 6, 2024

trigger: test-robottelo
pytest: tests/foreman/endtoend/test_cli_endtoend.py::test_positive_cli_end_to_end

1 similar comment
@pondrejk
Copy link
Contributor Author

pondrejk commented Feb 6, 2024

trigger: test-robottelo
pytest: tests/foreman/endtoend/test_cli_endtoend.py::test_positive_cli_end_to_end

Gauravtalreja1
Gauravtalreja1 reviewed Feb 6, 2024
View reviewed changes
tests/foreman/endtoend/test_cli_endtoend.py Outdated
Comment on lines 271 to 272
# check that content view matches what we passed
assert content_host['content-information']['content-view']['name'] == content_view['name']
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this information available in host info? just would like to understand why we're removing this assertion heere

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true, the problem is deeper, hammer output has got this information, but robottelo's parsed data doesn't. It would warrant further investigation, with this PR I'm mainly trying to restore the coverage

@pondrejk pondrejk mentioned this pull request Feb 15, 2024
Merged
@pondrejk
Copy link
Contributor Author

As per discussion #13989 im putting this to draft, I'll be working on a more systematic solution

@pondrejk pondrejk marked this pull request as draft February 15, 2024 16:45
@pondrejk pondrejk mentioned this pull request Feb 16, 2024
Closed
@pondrejk pondrejk marked this pull request as ready for review March 25, 2024 14:25
@pondrejk
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/endtoend/test_cli_endtoend.py::test_positive_cli_end_to_end

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6184
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/endtoend/test_cli_endtoend.py::test_positive_cli_end_to_end --external-logging
Test Result : ================== 1 failed, 1 warning in 1013.61s (0:16:53) ===================

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Mar 25, 2024
@pondrejk
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/endtoend/test_cli_endtoend.py::test_positive_cli_end_to_end

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6191
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/endtoend/test_cli_endtoend.py::test_positive_cli_end_to_end --external-logging
Test Result : =================== 1 failed, 1 warning in 939.00s (0:15:38) ===================

@pondrejk
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/endtoend/test_cli_endtoend.py::test_positive_cli_end_to_end

@Satellite-QE Satellite-QE removed the PRT-Failed Indicates that latest PRT run is failed for the PR label Mar 26, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6199
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/endtoend/test_cli_endtoend.py::test_positive_cli_end_to_end --external-logging
Test Result : ================== 1 failed, 1 warning in 1057.73s (0:17:37) ===================

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Mar 26, 2024
@pondrejk pondrejk added No-CherryPick PR doesnt need CherryPick to previous branches and removed CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing labels Mar 27, 2024
@pondrejk pondrejk removed 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Mar 27, 2024
@pondrejk pondrejk mentioned this pull request Mar 27, 2024
Merged
This was referenced Mar 27, 2024
Merged
Merged
vsedmik
vsedmik requested changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One recommendation regarding SCA-only

tests/foreman/endtoend/test_cli_endtoend.py Outdated
@@ -110,7 +110,7 @@ def test_positive_cli_end_to_end(function_entitlement_manifest, target_sat, rhel

# step 2.1: Create a new organization
org = _create(user, target_sat.cli.Org, {'name': gen_alphanumeric()})
target_sat.cli.SimpleContentAccess.disable({'organization-id': org['id']})
# target_sat.cli.SimpleContentAccess.disable({'organization-id': org['id']})
Copy link
Contributor

@vsedmik vsedmik Mar 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed for good in master/6.16 since it is SCA-only.

Also I would recommend to use function_sca_manifest instead and remove this (failing in PRT) as not applicable in the SCA-only org.

@pondrejk
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/endtoend/test_cli_endtoend.py::test_positive_cli_end_to_end

@Satellite-QE Satellite-QE removed the PRT-Failed Indicates that latest PRT run is failed for the PR label Mar 28, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6239
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/endtoend/test_cli_endtoend.py::test_positive_cli_end_to_end --external-logging
Test Result : ================== 1 passed, 5 warnings in 1143.43s (0:19:03) ==================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Mar 28, 2024
@pondrejk
Copy link
Contributor Author

@Gauravtalreja1 @vsedmik prt passing now, can you please revisit?

vsedmik
vsedmik approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pondrejk pondrejk merged commit c736ab4 into SatelliteQE:master Apr 8, 2024
10 checks passed
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
@pondrejk @shweta83
cli e2e fix (SatelliteQE#13999)
701b97d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 left review comments

@vsedmik vsedmik vsedmik approved these changes

Assignees

@pondrejk pondrejk

Labels
CLI Issues and PRs involving the CLI No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR TestFailure Issues and PRs related to a test failing in automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pondrejk @Satellite-QE @Gauravtalreja1 @vsedmik