Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the auto-cherry-picking issue cause due github action failure #14016

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

omkarkhatavkar
Copy link

@omkarkhatavkar omkarkhatavkar commented Feb 8, 2024

Problem Statement

Previously, community GitHub actions were encountering issues where they persisted in identifying base issues even after they had been merged, failing to trigger issue creation as intended. Despite thorough testing, these issues persisted, prompting a reassessment of the underlying logic.

Solution

To address this recurring problem, I have implemented a custom bash script to ensure accurate behavior and resolve the persistence of identifying merged base issues. By relying on our bash script, I aim to mitigate these issues effectively. Further testing is required to validate the efficacy of this solution thoroughly.

Related Issues

many cherrypicks are not getting raised :
https://github.com/SatelliteQE/robottelo/actions/workflows/auto_cherry_pick.yml?query=is%3Afailure
https://github.com/SatelliteQE/robottelo/actions/runs/7819038827

Tested Conditions

@omkarkhatavkar omkarkhatavkar requested a review from a team as a code owner February 8, 2024 13:11
@omkarkhatavkar omkarkhatavkar changed the title fixed the auto-cherry-picking issue cause due git-hub action failure fixed the auto-cherry-picking issue cause due github action failure Feb 8, 2024
@omkarkhatavkar omkarkhatavkar added the No-CherryPick PR doesnt need CherryPick to previous branches label Feb 8, 2024
@omkarkhatavkar
Copy link
Author

@jyejare @Gauravtalreja1 Can we please review this on priority and merge?

Copy link
Member

@jyejare jyejare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, but repair the faulty message in PR created check or wherever applicable OR correct me if I am wrong.

Though the cherrypick PR is created verified and the check is passed, the message it shows is weird.

Screenshot 2024-02-09 at 2 28 31 PM

@omkarkhatavkar
Copy link
Author

ACK, but repair the faulty message in PR created check or wherever applicable OR correct me if I am wrong.

Though the cherrypick PR is created verified and the check is passed, the message it shows is weird.

Screenshot 2024-02-09 at 2 28 31 PM

That was the wrong action run I added in the comment, see this one https://github.com/omkarkhatavkar/robottelo/actions/runs/7830716259/job/21365439760, it works fine.

@omkarkhatavkar omkarkhatavkar added 6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 CherryPick PR needs CherryPick to previous branches and removed No-CherryPick PR doesnt need CherryPick to previous branches labels Feb 12, 2024
@jyejare jyejare merged commit 66a62d9 into SatelliteQE:master Feb 12, 2024
12 checks passed
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
…atelliteQE#14016)

fixed the auto-cherry-picking issue cause due git-hub action failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 CherryPick PR needs CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants