Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix registration test cases #14026

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Fix registration test cases #14026

merged 1 commit into from
Feb 15, 2024

Conversation

shweta83
Copy link
Contributor

@shweta83 shweta83 commented Feb 9, 2024

Problem Statement

Manual cherrypick for https://github.com/SatelliteQE/robottelo/pull/13974/files

Solution

Related Issues

@shweta83 shweta83 added the No-CherryPick PR doesnt need CherryPick to previous branches label Feb 9, 2024
@shweta83 shweta83 force-pushed the cherrypick_613z_pr13974 branch 2 times, most recently from 0fc4a8e to dee9b24 Compare February 9, 2024 08:31
@shweta83
Copy link
Contributor Author

shweta83 commented Feb 9, 2024

trigger: test-robottelo
pytest: tests/foreman/api/test_registration.py

@shweta83 shweta83 mentioned this pull request Feb 9, 2024
Closed
@Gauravtalreja1 Gauravtalreja1 added the 6.13.z Introduced in or relating directly to Satellite 6.13 label Feb 9, 2024
Griffin-Sullivan
Griffin-Sullivan approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@Griffin-Sullivan Griffin-Sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the one failure is due to ansible-core requires a minimum of Python2 version 2.7 or Python3 version 3.5. Current version: 2.6.6. I wonder if this is a RHEL 6 issue? My team doesn't do much with RHEL6 Content Hosts. Is this an error anyone else has seen?

tests/foreman/ui/test_registration.py Outdated
Comment on lines 51 to 52
assert cmd['general']['operating_system'] == default_os.title
assert cmd['general']['operating_system'] == ''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the double assertion?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a cherry-pick issue. Corrected it.

@shweta83 shweta83 force-pushed the cherrypick_613z_pr13974 branch from dee9b24 to 69b9f41 Compare February 13, 2024 11:35
@shweta83
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_registration.py

@shweta83 shweta83 marked this pull request as draft February 13, 2024 11:58
@shweta83 shweta83 force-pushed the cherrypick_613z_pr13974 branch from 69b9f41 to cf42d26 Compare February 14, 2024 18:04
@shweta83
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_registration.py

@shweta83 shweta83 force-pushed the cherrypick_613z_pr13974 branch from cf42d26 to 754b78e Compare February 14, 2024 18:18
@shweta83
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_registration.py

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 5725
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_registration.py
Test Result : ============ 11 passed, 695 warnings, 1 error in 4305.80s (1:11:45) ============

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Feb 14, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 5726
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_registration.py
Test Result : ============ 11 passed, 697 warnings, 1 error in 4265.99s (1:11:05) ============

@shweta83 shweta83 marked this pull request as ready for review February 15, 2024 04:30
@shubhamsg199 shubhamsg199 merged commit ef626ff into SatelliteQE:6.13.z Feb 15, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubhamsg199 shubhamsg199 shubhamsg199 approved these changes

@Griffin-Sullivan Griffin-Sullivan Griffin-Sullivan approved these changes

Assignees

@shweta83 shweta83

Labels
6.13.z Introduced in or relating directly to Satellite 6.13 No-CherryPick PR doesnt need CherryPick to previous branches PRT-Failed Indicates that latest PRT run is failed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shweta83 @Satellite-QE @Griffin-Sullivan @shubhamsg199 @Gauravtalreja1