Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.14.z] Add test coverage for BZ:2192939 #14045

Merged
merged 1 commit into from
Feb 12, 2024
Merged

[6.14.z] Add test coverage for BZ:2192939 #14045

merged 1 commit into from
Feb 12, 2024

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #14025

Problem Statement

Missing test coverage for BZ:2192939, which verifies config report generated for host gets Puppet origin correctly, when reports are without any messages.

Solution

  1. Add test to validate config reports gets generated for host and has Puppet origin set correctly, when reports are without any messages.
  2. Updating configure_puppet helper to not run puppet agent if run_puppet_agent=False, after we sign agent's certificate.
  3. Furthermore, additional validation is added for the 'puppetmaster_fqdn' host fact, when puppetmaster is Sat/Cap server, and existing tests are updated accordingly.

@Gauravtalreja1 @web-flow
Add test coverage for BZ:2192939 (#14025)
76d850d 
* Add test coverage for BZ:2192939

Signed-off-by: Gaurav Talreja <[email protected]>

* Add :parametrized: keyword to test metadata

Co-authored-by: Shubham Ganar <[email protected]>

---------

Signed-off-by: Gaurav Talreja <[email protected]>
Co-authored-by: Shubham Ganar <[email protected]>
(cherry picked from commit 97d9117)
@Satellite-QE Satellite-QE added 6.14.z Introduced in or relating directly to Satellite 6.14 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Feb 12, 2024
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_report.py::test_positive_run_puppet_agent_generate_report_when_no_message

@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Feb 12, 2024
@Satellite-QE Satellite-QE merged commit 9154044 into 6.14.z Feb 12, 2024
22 checks passed
@Satellite-QE Satellite-QE deleted the cherry-pick-6.14.z-97d9117d74835665cad06b59d39ab5802a63b0ec branch February 12, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Gauravtalreja1 Gauravtalreja1

Labels
6.14.z Introduced in or relating directly to Satellite 6.14 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Satellite-QE @Gauravtalreja1