Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.15.z] setup_org_for_a_rh_repo fix #14075

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #13970

Problem Statement

AttributeError: 'Manifest' object has no attribute 'path'

Solution

Follow idiom of creating a temporary file and into it, copying an in-memory object, then using it as a file.

I'm not sure how and when it got broken, I hit it when looking at the results of test_negative_without_attach_with_lce. I haven't yet tested extensively to make sure this doesn't break function _setup_org_for_a_rh_repo in other cases but it seems like it couldn't have worked.

* setup_org_for_a_rh_repo fix

* Use helper

(cherry picked from commit 0e1e489)
@Satellite-QE Satellite-QE requested a review from a team as a code owner February 14, 2024 12:04
@Satellite-QE Satellite-QE added 6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Feb 14, 2024
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_activationkey.py::test_positive_add_redhat_and_custom_products tests/foreman/cli/test_host.py::test_negative_without_attach_with_lce tests/foreman/cli/test_reporttemplates.py::test_positive_generate_hostpkgcompare

@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Feb 14, 2024
@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 5718
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_activationkey.py::test_positive_add_redhat_and_custom_products tests/foreman/cli/test_host.py::test_negative_without_attach_with_lce tests/foreman/cli/test_reporttemplates.py::test_positive_generate_hostpkgcompare
Test Result : ============ 2 failed, 1 passed, 59 warnings in 1054.82s (0:17:34) =============

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Feb 14, 2024
@Gauravtalreja1 Gauravtalreja1 merged commit f39c808 into 6.15.z Feb 14, 2024
13 of 16 checks passed
@Gauravtalreja1 Gauravtalreja1 deleted the cherry-pick-6.15.z-0e1e4890e2a6496510a444a707f13dccfe6449b7 branch February 14, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches PRT-Failed Indicates that latest PRT run is failed for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants