Extend VMware provisioning tests for OS version check

[Gauravtalreja1]

Problem Statement

Bootdisk provisioning passes for VMware 8, but installed status isn't updated, we've BZ:2255264 reported for it,

Solution

Handling BZ:2255264 in automation while this is open, and extending the test to check OS version when provisioning is completed for all methods including bootdisk

[lhellebr]

I think you don't need to sat.execute and from there ssh to the host. You should be able to execute on the host directly, shouldn't you?
Otherwise LGTM.

[shubhamsg199]

trigger: test-robottelo
pytest: tests/foreman/cli/test_computeresource_vmware.py -k test_positive_provision_end_to_end
provisioning: true

[Gauravtalreja1]

trigger: test-robottelo
pytest: tests/foreman/cli/test_computeresource_vmware.py -k test_positive_provision_end_to_end
provisioning: true

[Satellite-QE]

PRT Result

Build Number: 5825
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_computeresource_vmware.py -k test_positive_provision_end_to_end
Test Result : =========================== short test summary info ============================

[Gauravtalreja1]

trigger: test-robottelo
pytest: tests/foreman/cli/test_computeresource_vmware.py -k test_positive_provision_end_to_end
provisioning: true

[Satellite-QE]

PRT Result

Build Number: 6331
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_computeresource_vmware.py -k test_positive_provision_end_to_end --external-logging --include-onprem-provisioning
Test Result : === 10 failed, 14 passed, 2 deselected, 454 warnings in 20493.66s (5:41:33) ====

[Gauravtalreja1]

trigger: test-robottelo
pytest: tests/foreman/cli/test_computeresource_vmware.py -k test_positive_provision_end_to_end
provisioning: true

[Satellite-QE]

PRT Result

Build Number: 6417
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_computeresource_vmware.py -k test_positive_provision_end_to_end --external-logging --include-onprem-provisioning
Test Result : ========== 2 failed, 2 deselected, 146 warnings in 3617.79s (1:00:17) ==========

[ogajduse]

co-reviewed with @rmynar

What is the status of this PR? Do you need any help with this one?
From what we see, [E 240410 13:32:18 exceptions:17] AuthenticationError: Key-based authentication failed. pops up when the test tries to connect to the host using broker.
Did you try to investigate the server logs? Enabling debug logging on SSHD where you are trying to connect is usually helpful in debugging these sorts of issues.

Also since the workaround is not present in the patch, I would recommend changing the PR title.

[Gauravtalreja1]

trigger: test-robottelo
pytest: tests/foreman/cli/test_computeresource_vmware.py -k test_positive_provision_end_to_end
provisioning: true

[Satellite-QE]

PRT Result

Build Number: 6849
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_computeresource_vmware.py -k test_positive_provision_end_to_end --external-logging --include-onprem-provisioning
Test Result : ========== 2 failed, 2 deselected, 145 warnings in 4594.32s (1:16:34) ==========

[Satellite-QE]

PRT Result

Build Number: 6850
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_computeresource_vmware.py -k test_positive_provision_end_to_end --external-logging --include-onprem-provisioning
Test Result : ========== 2 failed, 2 deselected, 145 warnings in 4915.86s (1:21:55) ==========

[rplevka]

is this actually necessary?
isn't
lambda: self.connect(key_filename=self.key_filename), universal for both cases?
you could still pass key_filename=None if it is not specified and it should work, shouldn't it?
https://github.com/SatelliteQE/broker/blob/master/broker/hosts.py#L117

[rplevka]

i noticed you have a hardcoded rhel8 here:
https://github.com/SatelliteQE/robottelo/pull/14094/files#diff-f5876fe03942ff6e50c18a8f2c95255cdca6f84b9956721a587abf7322fb73abR130
mind changing that, so it reflects the current rhel_ver parameter?

[rplevka]

You are setting yourself for a failure with this kind of version parsing

In [1]: '8.10'[-3:]
Out[1]: '.10'

also, that field might contain os name + version + some suffix, like beta or possibly eus.
I'd suggest to use nailgun to get the host info, which should resolve the os entity where you can directly access major and minor versions.

[github-actions]

This pull request has not been updated in the past 45 days.

[jameerpathan111]

@Gauravtalreja1 I'm converting pr to draft for now, please mark it ready for review once you're done with changes/addressing the comments.