Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.14.z] Fix useless asserts in installer tests #14129

Merged
merged 1 commit into from
Feb 20, 2024
Merged

[6.14.z] Fix useless asserts in installer tests #14129

merged 1 commit into from
Feb 20, 2024
+12 −4

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #14099

Fixing assertions that were always True and therefore useless.

Note: bool("any string with non-zero length") is True, True or False is True

@rmynar @web-flow
Fix useless asserts in installer tests (#14099)
b2d422a 
fix useless asserts

(cherry picked from commit 44ee8bf)
@Satellite-QE Satellite-QE added 6.14.z Introduced in or relating directly to Satellite 6.14 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Feb 19, 2024
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/destructive/test_installer.py::test_installer_sat_pub_directory_accessibility tests/foreman/installer/test_installer.py::test_installer_cap_pub_directory_accessibility

@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 5785
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/destructive/test_installer.py::test_installer_sat_pub_directory_accessibility tests/foreman/installer/test_installer.py::test_installer_cap_pub_directory_accessibility
Test Result : ================= 2 passed, 124 warnings in 2934.35s (0:48:54) =================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Feb 19, 2024
@pondrejk pondrejk merged commit c5e7b95 into 6.14.z Feb 20, 2024
22 checks passed
@pondrejk pondrejk deleted the cherry-pick-6.14.z-44ee8bf96b94c354b749be398189b01241b36eb5 branch February 20, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pondrejk pondrejk pondrejk approved these changes

Assignees

@rmynar rmynar

Labels
6.14.z Introduced in or relating directly to Satellite 6.14 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Satellite-QE @pondrejk @rmynar