Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCA refactor of Subscription HTTP proxy test #14133

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented Feb 20, 2024

Problem Statement

As 6.16 is SCA-only we need to get rid of entitlements and subscriptions related logic in our tests but keep the approach user take for this or similar scenario.

Solution

Get rid of entitlements/subscriptions. Also I propose to change this test case to e2e since it syncs a RH repo, publishes and promotes it to an LCE, registers a content host via AK and consumes the content in it. Case remain parametrized to run with authenticated, unauthenticated and without (this param could be probably omited) HTTP proxy.

One minor update in enable_sync_redhat_repo so that we can use repos from constants which define arch key instead of basearch or even no arch at all.

Open question: Should the test id be changed since it doesn't cover the subscription manipulation at all?

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/api/test_http_proxy.py -k install_content_with_http_proxy

@vsedmik vsedmik added the No-CherryPick PR doesnt need CherryPick to previous branches label Feb 20, 2024
@vsedmik vsedmik self-assigned this Feb 20, 2024
@vsedmik vsedmik requested review from a team as code owners February 20, 2024 13:12
@vsedmik
Copy link
Contributor Author

vsedmik commented Feb 20, 2024

trigger: test-robottelo
pytest: tests/foreman/api/test_http_proxy.py -k install_content_with_http_proxy

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 5802
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_http_proxy.py -k install_content_with_http_proxy
Test Result : ========== 3 passed, 5 deselected, 112 warnings in 987.15s (0:16:27) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Feb 20, 2024
@jameerpathan111
Copy link
Contributor

jameerpathan111 commented Feb 20, 2024

Get rid of entitlements/subscriptions. Also I propose to change this test case to e2e since it syncs a RH repo, publishes and promotes it to an LCE, registers a content host via AK and consumes the content in it. Case remain parametrized to run with authenticated, unauthenticated and without (this param could be probably omited) HTTP proxy.

Open question: Should the test id be changed since it doesn't cover the subscription manipulation at all?

@vsedmik I think it's better to keep it the same as it's still in a way testing the HTTP proxy functionalities with subscription/manifest.
The only thing I'd recommend checking is whether the code from function_sca_manifest_org gets executed before or after the Http Proxy is set. If it's not happening then I'd even recommend adding the manifest upload code to the test itself.

@jameerpathan111 jameerpathan111 self-requested a review February 20, 2024 14:12
@vsedmik
Copy link
Contributor Author

vsedmik commented Feb 20, 2024

The only thing I'd recommend checking is whether the code from function_sca_manifest_org gets executed before or after the Http Proxy is set. If it's not happening then I'd even recommend adding the manifest upload code to the test itself.

As far as I can see the manifest is uploaded AFTER the HTTP proxy is set. So from this point of view we should be safe I guess. But good point anyway!

@jameerpathan111 jameerpathan111 merged commit 285315d into SatelliteQE:master Feb 21, 2024
9 checks passed
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants